Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming changes & reorganization of buttons for deverification in adminJS #1847

Closed
divine-comedian opened this issue Oct 1, 2024 · 7 comments
Assignees

Comments

@divine-comedian
Copy link
Collaborator

divine-comedian commented Oct 1, 2024

We should consider re-naming some to make it more clear for admins

rename Verify and Reject on Project tab to "approve vouched" & "remove vouched"

change name of Revoke Badge = "Revoke GIVbacks Eligible"

image

anything else to add here? @NikolaCreatrix @WhyldWanderer

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Oct 1, 2024
@divine-comedian divine-comedian moved this from New Issues to Product Research in All-Devs Oct 1, 2024
@divine-comedian divine-comedian changed the title naming changes for deverification in adminJS naming changes & reorganization of buttons for deverification in adminJS Oct 1, 2024
@WhyldWanderer
Copy link

I think that covers it Mitch!

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 3, 2024

  • when I tap on "reject" button in project page the verified status is changed to NO(pic 1) but I still see "vouched" tag in project page (pic 2)

Is it a bug or the development hasn't been completed yet?

image

image

https://staging.giveth.io/project/testdraft?tab=givpower

@RamRamez @divine-comedian

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 3, 2024

  • should the name of "verification status" be changed?

image

@divine-comedian

@RamRamez
Copy link
Collaborator

RamRamez commented Oct 3, 2024

  • when I tap on "reject" button in project page the verified status is changed to NO(pic 1) but I still see "vouched" tag in project page (pic 2)

Is it a bug or the development hasn't been completed yet?

image

image

https://staging.giveth.io/project/testdraft?tab=givpower

@RamRamez @divine-comedian

I'm not sure why we use both "verified" and "isGivbackEligible" fields for showing "vouched" badge in FE.
https://github.com/Giveth/giveth-dapps-v2/blob/2bcbfe0f90530e006f29467b8a701145d3c73ec3/src/components/views/project/ProjectBadges.tsx#L28

@RamRamez RamRamez moved this from Product Research to QA in All-Devs Oct 3, 2024
@RamRamez

This comment was marked as resolved.

@divine-comedian
Copy link
Collaborator Author

@maryjaf these are good observations and we can follow them up in a later issue after this pending release - for now let's stick to the bullet points Ramin shared above

@divine-comedian divine-comedian moved this from QA to Done in All-Devs Oct 3, 2024
@divine-comedian
Copy link
Collaborator Author

tested this out - renaming looks good and the buttons functions still work as expected!

image

@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 3, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged to Production
Development

No branches or pull requests

6 participants