Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different key for storing the unique id #24

Closed
justafish opened this issue Apr 3, 2020 · 4 comments
Closed

Use a different key for storing the unique id #24

justafish opened this issue Apr 3, 2020 · 4 comments
Assignees
@AronNovak

Comments

@justafish
Copy link

Currently this is being stored in logs_http.settings.uuid, but that can't be overridden from settings.php etc because it makes Drupal very unhappy
@amitaibu
Copy link
Member

Nancy!! 😄

because it makes Drupal very unhappy

In what ways does it make unhappy?

@justafish
Copy link
Author

Ok maybe not more unhappy than it usually is 😉
You just can't override the value, I presume because the config system doesn't let you override keys called uuid as they're reserved for internal usage

@justafish
Copy link
Author

This is how I got round this https://github.com/justafish/drupal_datadog/blob/1.x/src/DatadogLogsHttpLogger.php#L54

@amitaibu
Copy link
Member

Yeah, we should solve it. First lets get tests working back - #25

@amitaibu amitaibu mentioned this issue Jun 10, 2020
Closed
@RoSk0 RoSk0 mentioned this issue Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AronNovak AronNovak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AronNovak @amitaibu @justafish