Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Hardcoded Emojis #893

Closed
Glazelf opened this issue Jul 22, 2024 · 1 comment · Fixed by #928
Closed

Deprecate Hardcoded Emojis #893

Glazelf opened this issue Jul 22, 2024 · 1 comment · Fixed by #928
Assignees
Labels
low priority will fix (later) optimization Code optimization end users will not/barely notice

Comments

@Glazelf
Copy link
Owner

Glazelf commented Jul 22, 2024

Feature Description

Remove hardcoded emote jsons in favour of finding the emotes in the bot's available emotes.
As these emotes are added to the bot they are likely always available through some cache property on the client but we'll have to see how Discord.JS implements these.

Depends on discordjs/discord.js#10399 so likely has to wait untill 14.16.0.

@Glazelf Glazelf added the enhancement New feature or request label Jul 22, 2024
@Glazelf Glazelf self-assigned this Jul 22, 2024
@Glazelf Glazelf changed the title Hardcoded Emotes Deprecate Hardcoded Emotes Jul 22, 2024
@Glazelf Glazelf changed the title Deprecate Hardcoded Emotes Deprecate Hardcoded Emojis Jul 22, 2024
@Glazelf Glazelf added optimization Code optimization end users will not/barely notice and removed enhancement New feature or request labels Jul 24, 2024
@Glazelf Glazelf added the low priority will fix (later) label Sep 2, 2024
@Glazelf
Copy link
Owner Author

Glazelf commented Sep 3, 2024

Might require a lot of fetches that impact command speed with poor scalability since all emojis (up to 2000 objects) would need to be filtered and/or looped through, making the current hardcoded emoji-objects a better approach.
Looking into this. Many such cases.

@Glazelf Glazelf linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority will fix (later) optimization Code optimization end users will not/barely notice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant