Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Craft 3.2 Compatibility #3

Closed
lukasNo1 opened this issue Jul 23, 2019 · 2 comments
Closed

Craft 3.2 Compatibility #3

lukasNo1 opened this issue Jul 23, 2019 · 2 comments
Assignees
@christianruhstaller
Labels
bug Something isn't working

Comments

@lukasNo1
Copy link
Contributor

The plugin currently doesnt work under Craft 3.2 (tested with 3.2.4.1)

Craft 3.2 made some changes to drafts and the according functions.
These need to be reflected in the plugin.

Declaration of goldinteractive\publisher\elements\db\EntryPublishQuery::draftId(int $value) must be compatible with craft\elements\db\ElementQuery::draftId(?int $value = NULL)
@christianruhstaller christianruhstaller self-assigned this Jul 23, 2019
@christianruhstaller christianruhstaller added the bug Something isn't working label Jul 23, 2019
@christianruhstaller
Copy link
Member

This is not the only problem with the 3.2 version. There are some conceptual things we need to consider as the drafts do have quite a different behavior than before.

For this I opened an issue craftcms/cms#4642 with Craft CMS.

@christianruhstaller
Copy link
Member

The release 2.0.0 should now be compatible with Craft 3.2.

https://github.com/Goldinteractive/craft3-publisher/releases/tag/2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christianruhstaller christianruhstaller

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christianruhstaller @lukasNo1