Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula rules: no need for timestep if delta_a doesn't appear #95

Open
timhutton opened this issue Dec 30, 2020 · 0 comments
Open

Formula rules: no need for timestep if delta_a doesn't appear #95

timhutton opened this issue Dec 30, 2020 · 0 comments

Comments

@timhutton
Copy link
Member

Currently, formula rules such as Experiments/CornusAmmonis/smoke.vti have to declare a timestep parameter even though they write directly into a and don't use delta_a. The generated kernel source includes the forward Euler step even though it isn't used.

Should include forward-Euler for only those chemicals that write into delta_chem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant