Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the ui and logic behind start date and end date #19

Closed
mr-palindrome opened this issue Oct 10, 2022 · 11 comments · Fixed by #48
Closed

Enhance the ui and logic behind start date and end date #19

mr-palindrome opened this issue Oct 10, 2022 · 11 comments · Fixed by #48
Assignees

Comments

@mr-palindrome
Copy link
Collaborator

mr-palindrome commented Oct 10, 2022

Propose changes

  • Enhance the start date and end date ui and add a logic which will not allow one to select a date which is less than the start date.
  • Change the react logic behind the date

image

we want something like this:

image

@nirajpdn
Copy link
Contributor

Alright, i am ready to do this.

@Dhruv031003
Copy link
Collaborator

Yeah go ahead!

@Dhruv031003
Copy link
Collaborator

@nirajpdn Any Updates??

@nirajpdn
Copy link
Contributor

@Dhruv031003 I will push today

@nirajpdn
Copy link
Contributor

@Dhruv031003 @mr-palindrome, so now we have two seperate fields for startDate and endDate. I should work in seperate fields and fix the logic or i have to use only one field provided by date range picker as shown in image above.

@Dhruv031003
Copy link
Collaborator

@nirajpdn
You can use two fields or one it's upto you. But make sure we have option to select both start date and end date,
And one should not be able to select a start date less than end date and end date greater than start date.

@nirajpdn
Copy link
Contributor

@nirajpdn You can use two fields or one it's upto you. But make sure we have option to select both start date and end date, And one should not be able to select a start date less than end date and end date greater than start date.

Alright, thanks

@Dhruv031003
Copy link
Collaborator

@nirajpdn
any updates??

@alexsam29
Copy link
Contributor

alexsam29 commented Oct 23, 2022

Hi, I can work on this issue if the other person isn't responding. I feel like it's related to #37, which I also worked on.

@Dhruv031003
Copy link
Collaborator

Hi @alexsam29
Yeah sure you can work on this.
Just wait till I merge #43

  • He made some changes in the date-picker while updating the UI but it has some issues.
  • We still have to select the start date and end date seperately. So you can make it such that we can select both by opening the date picker once.

@Dhruv031003 Dhruv031003 assigned alexsam29 and unassigned nirajpdn Oct 23, 2022
@Dhruv031003
Copy link
Collaborator

@alexsam29
You can start your work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants