Version v0.15.2 and kill chrome instance

[diegogmez]

Hello!,

We have recently migrated the library from version v0.15.1 to v0.15.2 and we have encountered a problem

In the kill method the instance of the chrome that it returns when executing in launch() behaves differently:

v0.15.1 returned a promise
v0.15.2 returns a void

The readme documentation still persists with a promise. Is it an error in the documentation? Was this change expected?

[connorjclark]

This was changed in #269

Killing a process is really just sending a signal, which is synchronous, and is why the original interface of returning a Promise was not ideal. See https://nodejs.org/api/process.html#processkillpid-signal

We should update our documentation. Thanks for catching this!

[connorjclark]

BTW - it's important to note that if you are wanting to wait for confirmation that the process is gone, you'll have to listen to the child process's exit event: https://nodejs.org/api/child_process.html#event-exit

[diegogmez]

Perfect!!

Now we are using exactly the approach that you are suggesting but since in the previous implementation there was this promise, we were relying on it!. And that is rights we need some feedback / confirmation / error handling to be ensure there is not hang chrome process there :)

The main problem was the mismatch Documentation - Code :) but we always trust on the code hahahah

We can close the thread