fix(docker): added extra environment variable to lhci-client Dockerfile for puppeteer executable #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…le to specify the location of the installed chrome, since puppeteer's chromium download is skipped
Eliasvdb
force-pushed
the
lhci-client-docker-chrome-executable
branch
from
a03fa9f to
d2dcfa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I submitted #736 to fix issues with using puppeteer in the lhci-client docker image.
In the meantime, puppeteer seems broken again in the latest docker image version. After some investigation, this is most likely a problem occurring after the puppeteer upgrade from v13 to v19. In more recent versions, puppeteer keeps a cache of browser versions it downloads. Since in this image we skip the chromium download for puppeteer, because a chrome version is already included for the ligthouse tests, we should specify where our chrome version is located. This was quick fixable by passing the env var in the
docker conatiner runcommand, but should in my opinion be defined in the Dockerfile.