From 6a1715a1afcf494f5caeca07eb67abfdd71e5aef Mon Sep 17 00:00:00 2001 From: Justin Ribeiro Date: Fri, 7 Sep 2018 12:14:08 -0700 Subject: [PATCH] Update tests to Util.showAsPassed() --- .../html/renderer/performance-category-renderer-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js b/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js index 9c0cca41675a..d9e5154109c3 100644 --- a/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js +++ b/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js @@ -140,7 +140,7 @@ describe('PerfCategoryRenderer', () => { const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2]; const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' && - audit.result.score < Util.PASS_THRESHOLD && + !Util.showAsPassed(audit.result) && audit.result.scoreDisplayMode !== 'not-applicable'); const diagnosticElements = diagnosticSection.querySelectorAll('.lh-audit'); assert.equal(diagnosticElements.length, diagnosticAudits.length); @@ -152,7 +152,7 @@ describe('PerfCategoryRenderer', () => { const passedAudits = category.auditRefs.filter(audit => audit.group && audit.group !== 'metrics' && - (audit.result.score >= Util.PASS_THRESHOLD || + (Util.showAsPassed(audit.result) || audit.result.scoreDisplayMode === 'not-applicable')); const passedElements = passedSection.querySelectorAll('.lh-audit'); assert.equal(passedElements.length, passedAudits.length);