From c5040398098d68f569d04c35e0ba56aee2340769 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Fri, 2 Sep 2022 10:43:33 -0500 Subject: [PATCH] v9.6.7 (#14346) --- changelog.md | 33 ++++-- docs/plugins.md | 4 +- docs/recipes/custom-audit/package.json | 2 +- docs/recipes/gulp/package.json | 2 +- .../lighthouse-plugin-example/package.json | 2 +- .../test-definitions/perf-trace-elements.js | 1 + lighthouse-core/audits/lcp-lazy-loaded.js | 7 +- lighthouse-core/audits/network-requests.js | 1 + lighthouse-core/audits/preload-lcp-image.js | 10 +- .../gather/gatherers/trace-elements.js | 45 +++++--- .../largest-contentful-paint-element-test.js | 1 + .../test/audits/lcp-lazy-loaded-test.js | 27 ++++- .../test/audits/network-requests-test.js | 3 + .../test/audits/preload-lcp-image-test.js | 30 ++++- .../artifacts/sample-flow-artifacts.json | 6 +- .../reports/sample-flow-result.json | 106 ++++++++++++++---- .../gather/gatherers/trace-elements-test.js | 3 + .../test/results/artifacts/artifacts.json | 3 +- lighthouse-core/test/results/sample_v2.json | 47 +++++--- package.json | 2 +- .../lighthouse-emulate-run-expected.txt | 2 +- ...hthouse-successful-navigation-expected.txt | 2 +- .../lighthouse-successful-run-expected.txt | 2 +- types/artifacts.d.ts | 1 + 24 files changed, 257 insertions(+), 85 deletions(-) diff --git a/changelog.md b/changelog.md index 8d195584d741..539060dfb5e2 100644 --- a/changelog.md +++ b/changelog.md @@ -1,6 +1,17 @@ + +# 9.6.7 (2022-09-01) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.6...v9.6.7) + +This is an npm-only release. We have no plans to release this specific version to DevTools or PSI, but the changes will be rolled up into the next release in those clients. + +## Core + +* core(trace-elements): include LCP type in artifact ([#14344](https://github.com/GoogleChrome/lighthouse/pull/14344)) +* core: add priority to network-requests debug audit ([#14340](https://github.com/GoogleChrome/lighthouse/pull/14340)) + # 9.6.6 (2022-08-16) -[Full Changelog](https://github.com/compare/v9.6.5...v9.6.6) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.5...v9.6.6) We expect this release to ship in the DevTools of [Chrome 106](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -20,7 +31,7 @@ Thanks to our new contributor 👽🐷🐰🐯🐻! # 9.6.5 (2022-08-01) -[Full Changelog](https://github.com/compare/v9.6.4...v9.6.5) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.4...v9.6.5) This is an npm-only release and affects only the raw JSON report. We have no plans to release this specific version to DevTools or PSI, but the changes will be rolled up into the next release in those clients. @@ -31,7 +42,7 @@ This is an npm-only release and affects only the raw JSON report. We have no pla # 9.6.4 (2022-07-26) -[Full Changelog](https://github.com/compare/v9.6.3...v9.6.4) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.3...v9.6.4) We expect this release to ship in the DevTools of [Chrome 106](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -49,7 +60,7 @@ We expect this release to ship in the DevTools of [Chrome 106](https://chromiumd # 9.6.3 (2022-06-28) -[Full Changelog](https://github.com/compare/v9.6.2...v9.6.3) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.2...v9.6.3) This is an npm-only release and affects only the raw JSON report. We have no plans to release this specific version to DevTools or PSI, but the changes will be rolled up into the next release in those clients. @@ -60,7 +71,7 @@ This is an npm-only release and affects only the raw JSON report. We have no pla # 9.6.2 (2022-06-01) -[Full Changelog](https://github.com/compare/v9.6.1...v9.6.2) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.1...v9.6.2) We expect this release to ship in the DevTools of [Chrome 104](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -87,7 +98,7 @@ We expect this release to ship in the DevTools of [Chrome 104](https://chromiumd # 9.6.1 (2022-05-11) -[Full Changelog](https://github.com/compare/v9.6.0...v9.6.1) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.6.0...v9.6.1) We expect this release to ship in the DevTools of [Chrome 103](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -107,7 +118,7 @@ We expect this release to ship in the DevTools of [Chrome 103](https://chromiumd # 9.6.0 (2022-05-09) -[Full Changelog](https://github.com/compare/v9.5.0...v9.6.0) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.5.0...v9.6.0) We expect this release to ship in the DevTools of [Chrome 103](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -157,7 +168,7 @@ We expect this release to ship in the DevTools of [Chrome 103](https://chromiumd # 9.5.0 (2022-03-09) -[Full Changelog](https://github.com/compare/v9.4.0...v9.5.0) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.4.0...v9.5.0) We expect this release to ship in the DevTools of [Chrome 101](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -211,7 +222,7 @@ Thanks to our new contributor 👽🐷🐰🐯🐻! # 9.4.0 (2022-02-16) -[Full Changelog](https://github.com/compare/v9.3.1...v9.4.0) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.1...v9.4.0) We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. @@ -256,7 +267,7 @@ We expect this release to ship in the DevTools of [Chrome 100](https://chromiumd # 9.3.1 (2022-01-31) -[Full Changelog](https://github.com/compare/v9.3.0...v9.3.1) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.0...v9.3.1) ## Report @@ -264,7 +275,7 @@ We expect this release to ship in the DevTools of [Chrome 100](https://chromiumd # 9.3.0 (2022-01-31) -[Full Changelog](https://github.com/compare/v9.2.0...v9.3.0) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.2.0...v9.3.0) We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks. diff --git a/docs/plugins.md b/docs/plugins.md index 27e3c0a401ee..b4efe9142e4b 100644 --- a/docs/plugins.md +++ b/docs/plugins.md @@ -60,10 +60,10 @@ A Lighthouse plugin is just a node module with a name that starts with `lighthou "name": "lighthouse-plugin-cats", "main": "plugin.js", "peerDependencies": { - "lighthouse": "^9.6.6" + "lighthouse": "^9.6.7" }, "devDependencies": { - "lighthouse": "^9.6.6" + "lighthouse": "^9.6.7" } } ``` diff --git a/docs/recipes/custom-audit/package.json b/docs/recipes/custom-audit/package.json index 0e05b9f1b9ff..7cc41ca258fb 100644 --- a/docs/recipes/custom-audit/package.json +++ b/docs/recipes/custom-audit/package.json @@ -3,6 +3,6 @@ "private": true, "scripts": {}, "devDependencies": { - "lighthouse": "^9.6.6" + "lighthouse": "^9.6.7" } } diff --git a/docs/recipes/gulp/package.json b/docs/recipes/gulp/package.json index 23e4e7a34dd6..a43388b4e5e4 100644 --- a/docs/recipes/gulp/package.json +++ b/docs/recipes/gulp/package.json @@ -7,6 +7,6 @@ "devDependencies": { "gulp": "^3.9.1", "gulp-connect": "^5.0.0", - "lighthouse": "^9.6.6" + "lighthouse": "^9.6.7" } } diff --git a/docs/recipes/lighthouse-plugin-example/package.json b/docs/recipes/lighthouse-plugin-example/package.json index 11b044c12790..81b9d20f3ca3 100644 --- a/docs/recipes/lighthouse-plugin-example/package.json +++ b/docs/recipes/lighthouse-plugin-example/package.json @@ -3,7 +3,7 @@ "private": true, "main": "./plugin.js", "peerDependencies": { - "lighthouse": "^9.6.6" + "lighthouse": "^9.6.7" }, "devDependencies": { "lighthouse": "^8.6.0" diff --git a/lighthouse-cli/test/smokehouse/test-definitions/perf-trace-elements.js b/lighthouse-cli/test/smokehouse/test-definitions/perf-trace-elements.js index 941d6e12cd00..416ec9a7d63e 100644 --- a/lighthouse-cli/test/smokehouse/test-definitions/perf-trace-elements.js +++ b/lighthouse-cli/test/smokehouse/test-definitions/perf-trace-elements.js @@ -73,6 +73,7 @@ const expectations = { height: 318, }, }, + type: 'image', }, { traceEventType: 'layout-shift', diff --git a/lighthouse-core/audits/lcp-lazy-loaded.js b/lighthouse-core/audits/lcp-lazy-loaded.js index f9d75c889b30..35c2464cf1c0 100644 --- a/lighthouse-core/audits/lcp-lazy-loaded.js +++ b/lighthouse-core/audits/lcp-lazy-loaded.js @@ -50,8 +50,9 @@ class LargestContentfulPaintLazyLoaded extends Audit { * @return {LH.Audit.Product} */ static audit(artifacts) { - const lcpElement = artifacts.TraceElements - .find(element => element.traceEventType === 'largest-contentful-paint'); + const lcpElement = artifacts.TraceElements.find(element => { + return element.traceEventType === 'largest-contentful-paint' && element.type === 'image'; + }); const lcpElementImage = lcpElement ? artifacts.ImageElements.find(elem => { return elem.node.devtoolsNodePath === lcpElement.node.devtoolsNodePath; }) : undefined; @@ -59,7 +60,7 @@ class LargestContentfulPaintLazyLoaded extends Audit { if (!lcpElementImage || !this.isImageInViewport(lcpElementImage, artifacts.ViewportDimensions)) { - return {score: 1, notApplicable: true}; + return {score: null, notApplicable: true}; } /** @type {LH.Audit.Details.Table['headings']} */ diff --git a/lighthouse-core/audits/network-requests.js b/lighthouse-core/audits/network-requests.js index 2fef4c1a4adb..04aa0766470c 100644 --- a/lighthouse-core/audits/network-requests.js +++ b/lighthouse-core/audits/network-requests.js @@ -73,6 +73,7 @@ class NetworkRequests extends Audit { statusCode: record.statusCode, mimeType: record.mimeType, resourceType: record.resourceType, + priority: record.priority, isLinkPreload, experimentalFromMainFrame, lrEndTimeDeltaMs: endTimeDeltaMs, // Only exists on Lightrider runs diff --git a/lighthouse-core/audits/preload-lcp-image.js b/lighthouse-core/audits/preload-lcp-image.js index e7af53c57682..8ec3298f91c7 100644 --- a/lighthouse-core/audits/preload-lcp-image.js +++ b/lighthouse-core/audits/preload-lcp-image.js @@ -88,7 +88,7 @@ class PreloadLCPImageAudit extends Audit { /** * @param {LH.Artifacts.NetworkRequest} mainResource * @param {LH.Gatherer.Simulation.GraphNode} graph - * @param {LH.Artifacts.TraceElement|undefined} lcpElement + * @param {LH.Artifacts.TraceElement} lcpElement * @param {Array} imageElements * @return {{lcpNodeToPreload?: LH.Gatherer.Simulation.GraphNetworkNode, initiatorPath?: InitiatorPath}} */ @@ -121,14 +121,14 @@ class PreloadLCPImageAudit extends Audit { /** * Computes the estimated effect of preloading the LCP image. - * @param {LH.Artifacts.TraceElement|undefined} lcpElement + * @param {LH.Artifacts.TraceElement} lcpElement * @param {LH.Gatherer.Simulation.GraphNetworkNode|undefined} lcpNode * @param {LH.Gatherer.Simulation.GraphNode} graph * @param {LH.Gatherer.Simulation.Simulator} simulator * @return {{wastedMs: number, results: Array<{node: LH.Audit.Details.NodeValue, url: string, wastedMs: number}>}} */ static computeWasteWithGraph(lcpElement, lcpNode, graph, simulator) { - if (!lcpElement || !lcpNode) { + if (!lcpNode) { return { wastedMs: 0, results: [], @@ -222,6 +222,10 @@ class PreloadLCPImageAudit extends Audit { const lcpElement = artifacts.TraceElements .find(element => element.traceEventType === 'largest-contentful-paint'); + if (!lcpElement || lcpElement.type !== 'image') { + return {score: null, notApplicable: true}; + } + const [mainResource, lanternLCP, simulator] = await Promise.all([ MainResource.request({devtoolsLog, URL}, context), LanternLCP.request(metricData, context), diff --git a/lighthouse-core/gather/gatherers/trace-elements.js b/lighthouse-core/gather/gatherers/trace-elements.js index ff36e7543817..1ec0887cdcb9 100644 --- a/lighthouse-core/gather/gatherers/trace-elements.js +++ b/lighthouse-core/gather/gatherers/trace-elements.js @@ -24,7 +24,7 @@ const ProcessedNavigation = require('../../computed/processed-navigation.js'); const LighthouseError = require('../../lib/lh-error.js'); const ComputedResponsivenes = require('../../computed/metrics/responsiveness.js'); -/** @typedef {{nodeId: number, score?: number, animations?: {name?: string, failureReasonsMask?: number, unsupportedProperties?: string[]}[]}} TraceElementData */ +/** @typedef {{nodeId: number, score?: number, animations?: {name?: string, failureReasonsMask?: number, unsupportedProperties?: string[]}[], type?: string}} TraceElementData */ /** * @this {HTMLElement} @@ -213,6 +213,34 @@ class TraceElements extends FRGatherer { return animatedElementData; } + /** + * @param {LH.Artifacts.ProcessedTrace} processedTrace + * @param {LH.Gatherer.FRTransitionalContext} context + * @return {Promise<{nodeId: number, type: string} | undefined>} + */ + static async getLcpElement(processedTrace, context) { + let processedNavigation; + try { + processedNavigation = await ProcessedNavigation.request(processedTrace, context); + } catch (err) { + // If we were running in timespan mode and there was no paint, treat LCP as missing. + if (context.gatherMode === 'timespan' && err.code === LighthouseError.errors.NO_FCP.code) { + return; + } + + throw err; + } + + // These should exist, but trace types are loose. + const lcpData = processedNavigation.largestContentfulPaintEvt?.args?.data; + if (lcpData?.nodeId === undefined || !lcpData.type) return; + + return { + nodeId: lcpData.nodeId, + type: lcpData.type, + }; + } + /** * @param {LH.Gatherer.FRTransitionalContext} context */ @@ -241,26 +269,16 @@ class TraceElements extends FRGatherer { } const processedTrace = await ProcessedTrace.request(trace, context); - const {largestContentfulPaintEvt} = await ProcessedNavigation - .request(processedTrace, context) - .catch(err => { - // If we were running in timespan mode and there was no paint, treat LCP as missing. - if (context.gatherMode === 'timespan' && err.code === LighthouseError.errors.NO_FCP.code) { - return {largestContentfulPaintEvt: undefined}; - } - - throw err; - }); const {mainThreadEvents} = processedTrace; - const lcpNodeId = largestContentfulPaintEvt?.args?.data?.nodeId; + const lcpNodeData = await TraceElements.getLcpElement(processedTrace, context); const clsNodeData = TraceElements.getTopLayoutShiftElements(mainThreadEvents); const animatedElementData = await this.getAnimatedElements(mainThreadEvents); const responsivenessElementData = await TraceElements.getResponsivenessElement(trace, context); /** @type {Map} */ const backendNodeDataMap = new Map([ - ['largest-contentful-paint', lcpNodeId ? [{nodeId: lcpNodeId}] : []], + ['largest-contentful-paint', lcpNodeData ? [lcpNodeData] : []], ['layout-shift', clsNodeData], ['animation', animatedElementData], ['responsiveness', responsivenessElementData ? [responsivenessElementData] : []], @@ -299,6 +317,7 @@ class TraceElements extends FRGatherer { score: backendNodeData[i].score, animations: backendNodeData[i].animations, nodeId: backendNodeId, + type: backendNodeData[i].type, }); } } diff --git a/lighthouse-core/test/audits/largest-contentful-paint-element-test.js b/lighthouse-core/test/audits/largest-contentful-paint-element-test.js index 54b433525cdd..834d5525da88 100644 --- a/lighthouse-core/test/audits/largest-contentful-paint-element-test.js +++ b/lighthouse-core/test/audits/largest-contentful-paint-element-test.js @@ -20,6 +20,7 @@ describe('Performance: largest-contentful-paint-element audit', () => { nodeLabel: 'My Test Label', snippet: '

', }, + type: 'text', }], }; diff --git a/lighthouse-core/test/audits/lcp-lazy-loaded-test.js b/lighthouse-core/test/audits/lcp-lazy-loaded-test.js index 71ee3bd63354..ef4242bb3b89 100644 --- a/lighthouse-core/test/audits/lcp-lazy-loaded-test.js +++ b/lighthouse-core/test/audits/lcp-lazy-loaded-test.js @@ -34,6 +34,7 @@ describe('Performance: lcp-lazy-loaded audit', () => { TraceElements: [{ traceEventType: 'largest-contentful-paint', node: SAMPLE_NODE, + type: 'image', }], ImageElements: [ generateImage('lazy', 0), @@ -57,6 +58,7 @@ describe('Performance: lcp-lazy-loaded audit', () => { TraceElements: [{ traceEventType: 'largest-contentful-paint', node: SAMPLE_NODE, + type: 'image', }], ImageElements: [ generateImage('eager', 0), @@ -76,6 +78,7 @@ describe('Performance: lcp-lazy-loaded audit', () => { TraceElements: [{ traceEventType: 'largest-contentful-paint', node: SAMPLE_NODE, + type: 'image', }], ImageElements: [ generateImage('lazy', 700), @@ -96,7 +99,29 @@ describe('Performance: lcp-lazy-loaded audit', () => { }; const auditResult = await LargestContentfulPaintLazyLoaded.audit(artifacts); - expect(auditResult.score).toEqual(1); + expect(auditResult.score).toEqual(null); expect(auditResult.notApplicable).toEqual(true); }); + + it('is not applicable when LCP was text', async () => { + const artifacts = { + TraceElements: [{ + traceEventType: 'largest-contentful-paint', + node: SAMPLE_NODE, + type: 'text', + }], + ImageElements: [ + generateImage('lazy', 700), + ], + ViewportDimensions: { + innerHeight: 500, + innerWidth: 300, + }, + }; + const auditResult = await LargestContentfulPaintLazyLoaded.audit(artifacts); + expect(auditResult).toEqual({ + score: null, + notApplicable: true, + }); + }); }); diff --git a/lighthouse-core/test/audits/network-requests-test.js b/lighthouse-core/test/audits/network-requests-test.js index 13a0bdcf43d2..4c3eaae2edb8 100644 --- a/lighthouse-core/test/audits/network-requests-test.js +++ b/lighthouse-core/test/audits/network-requests-test.js @@ -36,6 +36,7 @@ describe('Network requests audit', () => { statusCode: 200, mimeType: 'text/html', resourceType: 'Document', + priority: 'VeryHigh', }); expect(output.details.items[2]).toMatchObject({ startTime: expect.toBeApproximately(711, 0), @@ -46,6 +47,7 @@ describe('Network requests audit', () => { statusCode: 200, mimeType: 'image/png', resourceType: 'Image', + priority: 'Low', }); expect(output.details.items[5]).toMatchObject({ startTime: expect.toBeApproximately(717, 0), @@ -56,6 +58,7 @@ describe('Network requests audit', () => { statusCode: 200, mimeType: 'application/javascript', resourceType: 'Script', + priority: 'Medium', }); expect(output.details.debugData).toStrictEqual({ diff --git a/lighthouse-core/test/audits/preload-lcp-image-test.js b/lighthouse-core/test/audits/preload-lcp-image-test.js index ef1b825ddafd..2c1b3fd5f233 100644 --- a/lighthouse-core/test/audits/preload-lcp-image-test.js +++ b/lighthouse-core/test/audits/preload-lcp-image-test.js @@ -33,7 +33,9 @@ describe('Performance: preload-lcp audit', () => { { traceEventType: 'largest-contentful-paint', node: { - devtoolsNodePath: '1,HTML,1,BODY,3,DIV,2,IMG'}, + devtoolsNodePath: '1,HTML,1,BODY,3,DIV,2,IMG', + }, + type: 'image', }, ], ImageElements: [ @@ -92,7 +94,31 @@ describe('Performance: preload-lcp audit', () => { ]; }; - it('shouldn\'t be applicable if lcp image is not found', async () => { + it('is not applicable if TraceElements does not include LCP', async () => { + const networkRecords = mockNetworkRecords(); + const artifacts = mockArtifacts(networkRecords, mainDocumentNodeUrl, imageUrl); + artifacts.TraceElements = []; + const context = {settings: {}, computedCache: new Map()}; + const result = await PreloadLCPImage.audit(artifacts, context); + expect(result).toEqual({ + score: null, + notApplicable: true, + }); + }); + + it('is not applicable if LCP was not an image', async () => { + const networkRecords = mockNetworkRecords(); + const artifacts = mockArtifacts(networkRecords, mainDocumentNodeUrl, imageUrl); + artifacts.TraceElements[0].type = 'text'; + const context = {settings: {}, computedCache: new Map()}; + const result = await PreloadLCPImage.audit(artifacts, context); + expect(result).toEqual({ + score: null, + notApplicable: true, + }); + }); + + it('shouldn\'t be applicable if lcp image element is not found', async () => { const networkRecords = mockNetworkRecords(); const artifacts = mockArtifacts(networkRecords, mainDocumentNodeUrl, imageUrl); artifacts.ImageElements = []; diff --git a/lighthouse-core/test/fixtures/fraggle-rock/artifacts/sample-flow-artifacts.json b/lighthouse-core/test/fixtures/fraggle-rock/artifacts/sample-flow-artifacts.json index 0f5e7a8b8c7a..40fce95e44d1 100644 --- a/lighthouse-core/test/fixtures/fraggle-rock/artifacts/sample-flow-artifacts.json +++ b/lighthouse-core/test/fixtures/fraggle-rock/artifacts/sample-flow-artifacts.json @@ -275560,7 +275560,8 @@ "snippet": "\"Mike's", "nodeLabel": "Mike's Cereal Shack Logo" }, - "nodeId": 15 + "nodeId": 15, + "type": "image" }, { "traceEventType": "layout-shift", @@ -919956,7 +919957,8 @@ "snippet": "", "nodeLabel": "div.flex > main#main-content > div.flex > img.rounded-md" }, - "nodeId": 902 + "nodeId": 902, + "type": "image" } ], "ViewportDimensions": { diff --git a/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json index 910d5ab20723..83674d8fa0e4 100644 --- a/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json +++ b/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json @@ -2,7 +2,7 @@ "steps": [ { "lhr": { - "lighthouseVersion": "9.6.5", + "lighthouseVersion": "9.6.7", "requestedUrl": "https://www.mikescerealshack.co/", "finalUrl": "https://www.mikescerealshack.co/", "fetchTime": "2022-03-08T15:35:57.356Z", @@ -760,6 +760,7 @@ "statusCode": 200, "mimeType": "text/html", "resourceType": "Document", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -773,6 +774,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -787,6 +789,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -800,6 +803,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -814,6 +818,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -828,6 +833,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -842,6 +848,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -856,6 +863,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -870,6 +878,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -884,6 +893,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -898,6 +908,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -912,6 +923,7 @@ "statusCode": 200, "mimeType": "image/svg+xml", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -925,6 +937,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -938,6 +951,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -951,6 +965,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -964,6 +979,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -977,6 +993,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -990,6 +1007,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Other", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -1003,6 +1021,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Other", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -1016,6 +1035,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Other", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -1029,6 +1049,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1042,6 +1063,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1055,6 +1077,7 @@ "statusCode": 200, "mimeType": "image/png", "resourceType": "Other", + "priority": "High", "experimentalFromMainFrame": true } ], @@ -7599,7 +7622,7 @@ }, { "lhr": { - "lighthouseVersion": "9.6.5", + "lighthouseVersion": "9.6.7", "requestedUrl": "https://www.mikescerealshack.co/", "finalUrl": "https://www.mikescerealshack.co/search?q=call+of+duty", "fetchTime": "2022-03-08T15:36:08.267Z", @@ -8175,7 +8198,8 @@ "resourceSize": 6631, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Script" + "resourceType": "Script", + "priority": "Low" }, { "url": "https://www.mikescerealshack.co/logo-text.svg", @@ -8187,7 +8211,8 @@ "resourceSize": 53947, "statusCode": 200, "mimeType": "image/svg+xml", - "resourceType": "Image" + "resourceType": "Image", + "priority": "High" }, { "url": "https://mnl4bjjsnz-dsn.algolia.net/1/indexes/dev_OFFICE_SCENES/query", @@ -8199,7 +8224,8 @@ "resourceSize": 0, "statusCode": 200, "mimeType": "text/plain", - "resourceType": "Preflight" + "resourceType": "Preflight", + "priority": "High" }, { "url": "https://mnl4bjjsnz-dsn.algolia.net/1/indexes/dev_OFFICE_SCENES/query", @@ -8211,7 +8237,8 @@ "resourceSize": 131342, "statusCode": 200, "mimeType": "application/json", - "resourceType": "Fetch" + "resourceType": "Fetch", + "priority": "High" }, { "url": "https://www.mikescerealshack.co/_next/static/chunks/pages/index-37980adf97404e76e41a.js", @@ -8223,7 +8250,8 @@ "resourceSize": 0, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Other" + "resourceType": "Other", + "priority": "VeryLow" }, { "url": "https://www.mikescerealshack.co/_next/static/chunks/pages/terms-0236318e86139dd7d7f2.js", @@ -8235,7 +8263,8 @@ "resourceSize": 0, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Other" + "resourceType": "Other", + "priority": "VeryLow" }, { "url": "https://www.mikescerealshack.co/_next/static/chunks/pages/privacy-864d3895f3c3722acef2.js", @@ -8247,7 +8276,8 @@ "resourceSize": 0, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Other" + "resourceType": "Other", + "priority": "VeryLow" }, { "url": "https://www.mikescerealshack.co/_next/static/chunks/pages/privacy-864d3895f3c3722acef2.js", @@ -8259,7 +8289,8 @@ "resourceSize": 720, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Script" + "resourceType": "Script", + "priority": "Low" }, { "url": "https://www.mikescerealshack.co/_next/static/chunks/pages/terms-0236318e86139dd7d7f2.js", @@ -8271,7 +8302,8 @@ "resourceSize": 11002, "statusCode": 200, "mimeType": "application/javascript", - "resourceType": "Script" + "resourceType": "Script", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s8/e13/128w/81d89db1bf3d43b5b21f813d2f2a9777.jpg", @@ -8283,7 +8315,8 @@ "resourceSize": 2379, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s3/e3/128w/9b3031eb3988ba363fe946929a79e016.jpg", @@ -8295,7 +8328,8 @@ "resourceSize": 2865, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s3/e3/128w/793a408ca63a660b5d7aa1a41ac126ca.jpg", @@ -8307,7 +8341,8 @@ "resourceSize": 1758, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s7/e11/128w/5d1df07b1741f4c3e66ed20ef00265f5.jpg", @@ -8319,7 +8354,8 @@ "resourceSize": 3267, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s8/e13/128w/b997cdb40263ff124e2a245c5e86a9a3.jpg", @@ -8331,7 +8367,8 @@ "resourceSize": 2596, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s8/e3/128w/08b3049589ca7ae688b0f771f9730caf.jpg", @@ -8343,7 +8380,8 @@ "resourceSize": 3110, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s8/e13/128w/f5c5012a2afa2ac6b190dcd68306dbac.jpg", @@ -8355,7 +8393,8 @@ "resourceSize": 3806, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s9/e9/128w/5fbc916d0fffb01af1225d4ec2ab001d.jpg", @@ -8367,7 +8406,8 @@ "resourceSize": 3032, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" }, { "url": "https://cdn.mikescerealshack.co/frames/s9/e9/128w/558dc2f7d9c947e5445fb3f1838cb62c.jpg", @@ -8379,7 +8419,8 @@ "resourceSize": 3324, "statusCode": 200, "mimeType": "image/jpeg", - "resourceType": "Image" + "resourceType": "Image", + "priority": "Low" } ], "debugData": { @@ -11065,7 +11106,7 @@ }, { "lhr": { - "lighthouseVersion": "9.6.5", + "lighthouseVersion": "9.6.7", "requestedUrl": "https://www.mikescerealshack.co/search?q=call+of+duty", "finalUrl": "https://www.mikescerealshack.co/search?q=call+of+duty", "fetchTime": "2022-03-08T15:36:22.894Z", @@ -15873,7 +15914,7 @@ }, { "lhr": { - "lighthouseVersion": "9.6.5", + "lighthouseVersion": "9.6.7", "requestedUrl": "https://www.mikescerealshack.co/corrections", "finalUrl": "https://www.mikescerealshack.co/corrections", "fetchTime": "2022-03-08T15:36:29.745Z", @@ -16643,6 +16684,7 @@ "statusCode": 200, "mimeType": "text/html", "resourceType": "Document", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -16656,6 +16698,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16670,6 +16713,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -16683,6 +16727,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16697,6 +16742,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16711,6 +16757,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16725,6 +16772,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16739,6 +16787,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16753,6 +16802,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16767,6 +16817,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16781,6 +16832,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -16795,6 +16847,7 @@ "statusCode": 200, "mimeType": "image/svg+xml", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -16808,6 +16861,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -16821,6 +16875,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -16834,6 +16889,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -16847,6 +16903,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -16860,6 +16917,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -16873,6 +16931,7 @@ "statusCode": 200, "mimeType": "font/woff2", "resourceType": "Font", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -16886,6 +16945,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Other", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -16899,6 +16959,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Other", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -16912,6 +16973,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Low", "experimentalFromMainFrame": true } ], diff --git a/lighthouse-core/test/gather/gatherers/trace-elements-test.js b/lighthouse-core/test/gather/gatherers/trace-elements-test.js index 1c252100f92a..a7bce37df46c 100644 --- a/lighthouse-core/test/gather/gatherers/trace-elements-test.js +++ b/lighthouse-core/test/gather/gatherers/trace-elements-test.js @@ -452,6 +452,7 @@ describe('Trace Elements gatherer - Animated Elements', () => { width: 30, height: 130, }, + type: 'text', }; const connectionStub = new Connection(); connectionStub.sendCommand = createMockSendCommandFn() @@ -528,6 +529,7 @@ describe('Trace Elements gatherer - Animated Elements', () => { width: 964, height: 18, }, + type: 'text', }; const animationNodeData = { traceEventType: 'animation', @@ -633,6 +635,7 @@ describe('Trace Elements gatherer - Animated Elements', () => { width: 30, height: 130, }, + type: 'text', }; const connectionStub = new Connection(); connectionStub.sendCommand = createMockSendCommandFn() diff --git a/lighthouse-core/test/results/artifacts/artifacts.json b/lighthouse-core/test/results/artifacts/artifacts.json index c30e6767f790..c5c9b914d2e3 100644 --- a/lighthouse-core/test/results/artifacts/artifacts.json +++ b/lighthouse-core/test/results/artifacts/artifacts.json @@ -12145,7 +12145,8 @@ "snippet": "

", "nodeLabel": "Do better web tester page" }, - "nodeId": 6 + "nodeId": 6, + "type": "text" }, { "traceEventType": "layout-shift", diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 00eb862a11bb..07aa0095572c 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -1,5 +1,5 @@ { - "lighthouseVersion": "9.6.6", + "lighthouseVersion": "9.6.7", "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", "finalUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", "fetchTime": "2021-09-07T20:11:11.853Z", @@ -1310,6 +1310,7 @@ "statusCode": 200, "mimeType": "text/html", "resourceType": "Document", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1323,6 +1324,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1336,6 +1338,7 @@ "statusCode": 404, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1349,6 +1352,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1362,6 +1366,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1375,6 +1380,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1388,6 +1394,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "isLinkPreload": true, "experimentalFromMainFrame": true }, @@ -1402,6 +1409,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1415,6 +1423,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1428,6 +1437,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1441,6 +1451,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryLow", "experimentalFromMainFrame": true }, { @@ -1454,6 +1465,7 @@ "statusCode": 404, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1467,6 +1479,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1480,6 +1493,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1493,6 +1507,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1506,6 +1521,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1519,6 +1535,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1532,6 +1549,7 @@ "statusCode": 200, "mimeType": "image/gif", "resourceType": "Image", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1545,6 +1563,7 @@ "statusCode": 200, "mimeType": "application/javascript", "resourceType": "Script", + "priority": "Medium", "experimentalFromMainFrame": true }, { @@ -1558,6 +1577,7 @@ "statusCode": 200, "mimeType": "text/javascript", "resourceType": "Script", + "priority": "Medium", "experimentalFromMainFrame": true }, { @@ -1571,6 +1591,7 @@ "statusCode": 200, "mimeType": "image/jpeg", "resourceType": "Image", + "priority": "High", "experimentalFromMainFrame": true }, { @@ -1584,6 +1605,7 @@ "statusCode": 200, "mimeType": "text/css", "resourceType": "Stylesheet", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1597,6 +1619,7 @@ "statusCode": 200, "mimeType": "text/html", "resourceType": "XHR", + "priority": "VeryHigh", "experimentalFromMainFrame": true }, { @@ -1610,6 +1633,7 @@ "statusCode": 200, "mimeType": "text/plain", "resourceType": "Image", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1623,6 +1647,7 @@ "statusCode": 200, "mimeType": "text/html", "resourceType": "Image", + "priority": "Low", "experimentalFromMainFrame": true }, { @@ -1636,6 +1661,7 @@ "statusCode": 404, "mimeType": "image/vnd.microsoft.icon", "resourceType": "Other", + "priority": "High", "experimentalFromMainFrame": true } ], @@ -2565,17 +2591,8 @@ "id": "preload-lcp-image", "title": "Preload Largest Contentful Paint image", "description": "Preload the image used by the LCP element in order to improve your LCP time. [Learn more](https://web.dev/optimize-lcp/#preload-important-resources).", - "score": 1, - "scoreDisplayMode": "numeric", - "numericValue": 0, - "numericUnit": "millisecond", - "displayValue": "", - "details": { - "type": "opportunity", - "headings": [], - "items": [], - "overallSavingsMs": 0 - } + "score": null, + "scoreDisplayMode": "notApplicable" }, "csp-xss": { "id": "csp-xss", @@ -8042,12 +8059,6 @@ "duration": 100, "entryType": "measure" }, - { - "startTime": 0, - "name": "lh:computed:LanternLargestContentfulPaint", - "duration": 100, - "entryType": "measure" - }, { "startTime": 0, "name": "lh:audit:csp-xss", diff --git a/package.json b/package.json index 8ead35a19f3a..fcc1f9caa2e7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "lighthouse", - "version": "9.6.6", + "version": "9.6.7", "description": "Automated auditing, performance metrics, and best practices for the web.", "main": "./lighthouse-core/index.js", "bin": { diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-emulate-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-emulate-run-expected.txt index 3ab68b5c4263..f1403e270d4d 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-emulate-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-emulate-run-expected.txt @@ -15,7 +15,7 @@ Analyze page load: enabled visible =============== Lighthouse Results =============== URL: http://127.0.0.1:8000/devtools/lighthouse/resources/lighthouse-emulate-pass.html -Version: 9.6.6 +Version: 9.6.7 formFactor: mobile screenEmulation: { "mobile": true, diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-navigation-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-navigation-expected.txt index 161737f0b1ed..7e20fd4ce7a0 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-navigation-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-navigation-expected.txt @@ -262,7 +262,7 @@ Generating results... =============== Lighthouse Results =============== URL: http://127.0.0.1:8000/devtools/lighthouse/resources/lighthouse-basic.html -Version: 9.6.6 +Version: 9.6.7 ViewportDimensions: { "innerWidth": 980, "innerHeight": 1743, diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt index 0baa8ee20f84..0b080fe69eec 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt @@ -373,7 +373,7 @@ Generating results... =============== Lighthouse Results =============== URL: http://127.0.0.1:8000/devtools/lighthouse/resources/lighthouse-basic.html -Version: 9.6.6 +Version: 9.6.7 ViewportDimensions: { "innerWidth": 980, "innerHeight": 1743, diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts index c07e707d01e5..e5a8fd9520f3 100644 --- a/types/artifacts.d.ts +++ b/types/artifacts.d.ts @@ -542,6 +542,7 @@ declare module Artifacts { node: NodeDetails; nodeId?: number; animations?: {name?: string, failureReasonsMask?: number, unsupportedProperties?: string[]}[]; + type?: string; } interface ViewportDimensions {