From d12363f52cf01c223fd824829811654f6d557b04 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Thu, 22 Aug 2019 16:34:34 -0700 Subject: [PATCH] new import control text (#9595) --- proto/lighthouse-result.proto | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/proto/lighthouse-result.proto b/proto/lighthouse-result.proto index d3d485782d2e..636bcd2564b0 100644 --- a/proto/lighthouse-result.proto +++ b/proto/lighthouse-result.proto @@ -1,10 +1,12 @@ syntax = "proto3"; +// This comment required for Lightrider import compatibility # header + import "google/protobuf/struct.proto"; import "google/protobuf/timestamp.proto"; import "google/protobuf/wrappers.proto"; -// This comment required for LightRider import compatibility +// This comment required for LightRider import compatibility # suffix // Canonical list of errors created by Lighthouse. enum LighthouseError { @@ -142,7 +144,8 @@ message LighthouseResult { // nullable list of strings google.protobuf.Value only_categories = 3; - // How Lighthouse was run, e.g. from the Chrome extension or from the npm module + // How Lighthouse was run, e.g. from the Chrome extension or from the npm + // module string channel = 4; } @@ -154,8 +157,8 @@ message LighthouseResult { // Message containing the performance timing data for the Lighthouse run message Timing { - - // Corresponds to: https://www.w3.org/TR/performance-timeline-2/#dom-performanceentry + // Corresponds to: + // https://www.w3.org/TR/performance-timeline-2/#dom-performanceentry message PerformanceEntry { string name = 1; string entry_type = 2; @@ -169,7 +172,8 @@ message LighthouseResult { // The total duration of Lighthouse's run google.protobuf.DoubleValue total = 1; - // Corresponds to: https://www.w3.org/TR/performance-timeline-2/#idl-def-performanceentrylist + // Corresponds to: + // https://www.w3.org/TR/performance-timeline-2/#idl-def-performanceentrylist repeated PerformanceEntry entries = 2; }