Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache start_url gatherer (strategy) #2342

Closed
wardpeet opened this issue May 23, 2017 · 1 comment
Closed

Improve cache start_url gatherer (strategy) #2342

wardpeet opened this issue May 23, 2017 · 1 comment

Comments

@wardpeet
Copy link
Collaborator

There are a few issues with start_url being cached.

  1. of them is that the manifest is not cached and can not be retrieved.
  2. Another is that the start_url is not yet cached by the service worker.

There are a couple of solutions that we went over

  1. Cache manifest inside driver.js (getAppManifest). We cache the manifest during the main pass. And get it in the offline pass.
    -- Downside is that we always need another pass (which is not ideal).
  2. Offline pass should navigate to start_url instead of the current url. We fix both issues with this fix. -- lighthouse needs to know about the manifest inside the runner which makes lighthouse smarter than we probably want to know
  3. Monitor the service worker and see what requests it caches
    -- tricky to do as we need to use the SW as our debug target.
  4. Read the requests inside the cache api.
    -- Not sure if this will work

If anyone has more ideas please let me know

@paulirish
Copy link
Member

Mostly outdated, but merging into #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants