Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Don't check for url twice, move the check to entry in core #2507

Closed
evenstensberg opened this issue Jun 15, 2017 · 2 comments
Closed

Suggestion: Don't check for url twice, move the check to entry in core #2507

evenstensberg opened this issue Jun 15, 2017 · 2 comments

Comments

@evenstensberg
Copy link
Contributor

Doing some digging and found this:

https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/index.js#L32

and later this

https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/gather/gather-runner.js#L323

Can we move the check to lighthouse-core/index instead?
@paulirish
Copy link
Member

the comment in index points out the relationship there... /index isn't used by the chrome extension or devtools build.

but perhaps it'd be fine to nuke the check in /index and keep the gather-runner one.

@evenstensberg
Copy link
Contributor Author

Gotcha, want me to send a PR?

@evenstensberg evenstensberg mentioned this issue Jul 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @evenstensberg