You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minify or dedupe report renderer js, css, and templates (included twice, for report rendering but also in a browserified bundle of ReportGenerator for html saving). Minifying just the JS before inlining would save about 75KB in viewer and lighthouse-background.
This could either use the assets already in the page (but we'd need a non-awkward/maintainable way to do so) so they only appear once, or we could replace brfs with a transform that minifies the JS/CSS/HTML before inlining it as a string (this approach would also fix lighthouse-background contains un-minified report-renderer v2 #2014)
Experiment with versioned viewer/report scripts so old JSON results can still be loaded in viewer. May be less of a priority since we want to maintain some level of backwards compatibility so that DevTools can load old JSON reports.
Could do this with a script that checks the version and redirects to a specific URL per LH version (easy), or could split viewer and report into separate bundles and load the right report bundle based on json version (harder).
PWAify Viewer
Switch Viewer to use event-based ga and logging, like report does.
Explore CSP options (for extension and HTML report, as well)
Verify that report is actually isolated to its container so that when the container is cleared the report is actually cleared. It's likely that event listeners, references, etc remain every time a new report is loaded.
Viewer could easily be added to the report compile step since they're designed to be loaded in the page at the same time. Would need to write idbKeyval and firebase externs.
The text was updated successfully, but these errors were encountered:
Reduce asset sizes:
Minify or dedupe report renderer js, css, and templates (included twice, for report rendering but also in a browserified bundle of
ReportGenerator
for html saving). Minifying just the JS before inlining would save about 75KB in viewer and lighthouse-background.This could either use the assets already in the page (but we'd need a non-awkward/maintainable way to do so) so they only appear once, or we could replace
brfs
with a transform that minifies the JS/CSS/HTML before inlining it as a string (this approach would also fix lighthouse-background contains un-minified report-renderer v2 #2014)Resize
lh_logo_bg.png
closer to the size it appears on screen (formerlyViewer: resize lh_logo_bg.png #1569)Minify in-page CSS (formerly
Viewer: minify style.css for production. #1552)Experiment with versioned viewer/report scripts so old JSON results can still be loaded in viewer. May be less of a priority since we want to maintain some level of backwards compatibility so that DevTools can load old JSON reports.
Could do this with a script that checks the version and redirects to a specific URL per LH version (easy), or could split viewer and report into separate bundles and load the right report bundle based on json version (harder).
PWAify Viewer
Switch Viewer to use event-based ga and logging, like report does.
Explore CSP options (for extension and HTML report, as well)
Verify that report is actually isolated to its container so that when the container is cleared the report is actually cleared. It's likely that event listeners, references, etc remain every time a new report is loaded.
Viewer could easily be added to the report compile step since they're designed to be loaded in the page at the same time. Would need to write
idbKeyval
andfirebase
externs.The text was updated successfully, but these errors were encountered: