Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Viewer 2.0 Improvements #2591

Open
9 tasks
brendankenny opened this issue Jun 23, 2017 · 0 comments
Open
9 tasks

Possible Viewer 2.0 Improvements #2591

brendankenny opened this issue Jun 23, 2017 · 0 comments

Comments

@brendankenny
Copy link
Member

brendankenny commented Jun 23, 2017

  • Reduce asset sizes:

  • Experiment with versioned viewer/report scripts so old JSON results can still be loaded in viewer. May be less of a priority since we want to maintain some level of backwards compatibility so that DevTools can load old JSON reports.

    Could do this with a script that checks the version and redirects to a specific URL per LH version (easy), or could split viewer and report into separate bundles and load the right report bundle based on json version (harder).

  • PWAify Viewer

  • Switch Viewer to use event-based ga and logging, like report does.

  • Explore CSP options (for extension and HTML report, as well)

  • Verify that report is actually isolated to its container so that when the container is cleared the report is actually cleared. It's likely that event listeners, references, etc remain every time a new report is loaded.

  • Viewer could easily be added to the report compile step since they're designed to be loaded in the page at the same time. Would need to write idbKeyval and firebase externs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@brendankenny @patrickhulce and others