Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore assets from an extension in text compression audit #2696

Closed
grappler opened this issue Jul 15, 2017 · 4 comments
Closed

Ignore assets from an extension in text compression audit #2696

grappler opened this issue Jul 15, 2017 · 4 comments

Comments

@grappler
Copy link

I have the Google Dictionary installed and when I run Lighthouse I get a message for /content.min.css text compression is not enabled.

It would be cool if Lighthouse could know what assets are being loaded by chrome extensions and which are being loaded by the site.

Lighthouse 2.2.1

@midzer
Copy link
Contributor

midzer commented Jul 15, 2017

Yeah, somehow installed extensions which alter DOM in any way interfere with lighthouse scanning process.

This might be not the case in Chromium 60 any more when lighthouse is directly integrated into the browser.

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jul 17, 2017

good catch @grappler thanks for the report! It's not possible to avoid false positives for all extension activity, but this is an easy case we're not covering.

We really just need to check that the scheme is not chrome-extension here if anyone is interested in taking this up :)

@arturmiz
Copy link
Contributor

I volunteer to take a look on this one 👨‍💻

@patrickhulce
Copy link
Collaborator

awesome @arturmiz let us know if you have any questions!

@patrickhulce patrickhulce changed the title Enable text compression for Google Dictionary Extension Ignore assets from an extension in text compression audit Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants