Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve LHR differences between master/LHR-Lite/external service #4867

Closed
paulirish opened this issue Mar 26, 2018 · 1 comment · Fixed by #7991
Closed

Resolve LHR differences between master/LHR-Lite/external service #4867

paulirish opened this issue Mar 26, 2018 · 1 comment · Fixed by #7991
Assignees
@brendankenny
Labels
needs-priority
Milestone
Sprint Doce: Mar ...

Comments

@paulirish
Copy link
Member

I think we have 3 API shapes in play atm. Perhaps best way to work through the differences is a 3-column doc working through the LHR schema? I believe we now have all 3 defined in .d.ts.

We'll then need to:

  • Define the differences
  • decide on their resolution
  • get review from dgozman/caseq
  • submit a CL to external service to discuss changes with API owners
@paulirish paulirish mentioned this issue Mar 26, 2018
Closed
@paulirish
Copy link
Member Author

1-3 are complete.

@paulirish paulirish mentioned this issue Apr 20, 2018
Closed
82 tasks
@brendankenny brendankenny mentioned this issue Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendankenny brendankenny

Labels
needs-priority
Projects
None yet
Milestone
Sprint Doce: Mar 26 - April 6
Development

Successfully merging a pull request may close this issue.

misc: remove lhr-lite.d.ts GoogleChrome/lighthouse
2 participants
@paulirish @brendankenny