Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse PWA audits pass even with a JPG icon #4876

Closed
dfabulich opened this issue Mar 27, 2018 · 1 comment · Fixed by #6024
Closed

Lighthouse PWA audits pass even with a JPG icon #4876

dfabulich opened this issue Mar 27, 2018 · 1 comment · Fixed by #6024
Assignees

Comments

@dfabulich
Copy link

Chrome "Improved A2HS" requires a PNG icon in the Web Manifest file, but Lighthouse doesn't mention this in its PWA audits.

To reproduce:
Create a PWA with a JPG icon in its manifest.json, like this:

{
  "name": "Example",
  "short_name": "Example",
  "icons": [
    {
      "src": "icon.jpg",
      "sizes": "1024x1024",
      "type": "image/jpg"
    }
  ],
  "scope": "https://www.example.com/my-url/",
  "start_url": "https://www.example.com/my-url/",
  "display": "standalone",
  "background_color": "#626160",
  "theme_color": "#626160"
}

Expected: Lighthouse PWA audit should flag this manifest as ineligible for Web App Install Banner, because there's no PNG icon in this manifest.

Actual: All audits pass

@patrickhulce
Copy link
Collaborator

Thanks for the report @dfabulich! We can do better on this check along with #789 too 👍

@paulirish paulirish added the pwa label Aug 29, 2018
@paulirish paulirish changed the title Lighthouse PWA audits pass, but site not eligible for A2HS Lighthouse PWA audits pass even with a JPG icon Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants