We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome "Improved A2HS" requires a PNG icon in the Web Manifest file, but Lighthouse doesn't mention this in its PWA audits.
To reproduce: Create a PWA with a JPG icon in its manifest.json, like this:
manifest.json
{ "name": "Example", "short_name": "Example", "icons": [ { "src": "icon.jpg", "sizes": "1024x1024", "type": "image/jpg" } ], "scope": "https://www.example.com/my-url/", "start_url": "https://www.example.com/my-url/", "display": "standalone", "background_color": "#626160", "theme_color": "#626160" }
Expected: Lighthouse PWA audit should flag this manifest as ineligible for Web App Install Banner, because there's no PNG icon in this manifest.
Actual: All audits pass
The text was updated successfully, but these errors were encountered:
Thanks for the report @dfabulich! We can do better on this check along with #789 too 👍
Sorry, something went wrong.
exterkamp
Successfully merging a pull request may close this issue.
Chrome "Improved A2HS" requires a PNG icon in the Web Manifest file, but Lighthouse doesn't mention this in its PWA audits.
To reproduce:
Create a PWA with a JPG icon in its
manifest.json
, like this:Expected: Lighthouse PWA audit should flag this manifest as ineligible for Web App Install Banner, because there's no PNG icon in this manifest.
Actual: All audits pass
The text was updated successfully, but these errors were encountered: