-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale Support #5007
Comments
Willing to work on this, but what do you mean with locale? Formatting scores to be displayed for certain languages or formats? |
Specifically, translations for the explanations and instructions |
Alright, thanks for elaborating @sgryschuk-va! @patrickhulce is this up for grabs? |
I think we need to do a bit of scoping before we jump in on impl for this one @ev1stensberg. A few things to figure out:
We'll try and tackle some of these questions in our next triage post-I/O :) |
May I suggest starting with the Lighthouse Report Viewer ? I think it would be the easiest to implement IMO. We can download the json regardless of locale, upload it to the report viewer and switch the locale in there. Am I crazy? |
We support locales now (in master branch). :) This was tracked mostly by the #5719 ticket |
Will lighthouse support different locales?
PageSpeed insights does and has a lot of the same content
https://developers.google.com/speed/docs/insights/v4/reference/pagespeedapi/runpagespeed
The text was updated successfully, but these errors were encountered: