Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Support #5007

Closed
sgryschuk-va opened this issue Apr 20, 2018 · 6 comments
Closed

Locale Support #5007

sgryschuk-va opened this issue Apr 20, 2018 · 6 comments

Comments

@sgryschuk-va
Copy link

Will lighthouse support different locales?

PageSpeed insights does and has a lot of the same content
https://developers.google.com/speed/docs/insights/v4/reference/pagespeedapi/runpagespeed

@evenstensberg
Copy link
Contributor

Willing to work on this, but what do you mean with locale? Formatting scores to be displayed for certain languages or formats?

@sgryschuk-va
Copy link
Author

Specifically, translations for the explanations and instructions

@evenstensberg
Copy link
Contributor

Alright, thanks for elaborating @sgryschuk-va! @patrickhulce is this up for grabs?

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 3, 2018

I think we need to do a bit of scoping before we jump in on impl for this one @ev1stensberg.

A few things to figure out:

  • What channels would this affect/how would it be distributed?
    • DevTools doesn't offer translations, so we wouldn't apply it there
    • Extension as an option based on Chrome lang?
    • CLI/node flag and we ship all?
  • How does this impact linked docs/who maintains those?
  • How does this impact our PR process for text changes?
  • How high a priority is this/which languages are most urgent?

We'll try and tackle some of these questions in our next triage post-I/O :)

@zomars
Copy link

zomars commented May 28, 2018

May I suggest starting with the Lighthouse Report Viewer ? I think it would be the easiest to implement IMO. We can download the json regardless of locale, upload it to the report viewer and switch the locale in there. Am I crazy?

@paulirish
Copy link
Member

We support locales now (in master branch). :)

This was tracked mostly by the #5719 ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants