Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteEfficiency reports no savings in animated GIF->video cases #5017

Closed
paulirish opened this issue Apr 23, 2018 · 2 comments · Fixed by #5084
Closed

ByteEfficiency reports no savings in animated GIF->video cases #5017

paulirish opened this issue Apr 23, 2018 · 2 comments · Fixed by #5084
Assignees

Comments

@paulirish
Copy link
Member

repro:

  1. use new_audit: efficient-animated-content - use videos instead of gifs #4885
  2. lighthouse --perf https://gif.ski/ -GA

the report says its 100 even tho there was almost 5MB of savings.

image

why?

The computeWasteWithTTIGraph reports 0 savings because there's only 1 network request affected and no long tasks touched. However taking the end of each graph, the difference is 23 seconds.

Patrick said one option is to calculate impact on end of graph, rather than impact on estimated TTI. Onload would also be indicative especially when the focus is on 1 or 2 problematic requests. Both seem good to me.

@patrickhulce
Copy link
Collaborator

Yeah I think we decided after the original change that we're just trying to report "load"ish savings rathe than on specific metrics anyhow, it seems like savings on load instead of TTI is what we want in most cases (except offscreen images, render-blocking, etc where we're telling folks to "defer" rather than "eliminate")

@kaycebasques
Copy link
Contributor

I was going to suggest a GIF->video audit in response to Jeremy's new article, but it looks like this issue covers it

https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/replace-animated-gifs-with-video/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants