Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools Error: INVALID_URL when trying to audit extension #6421

Closed
eridiniara opened this issue Oct 29, 2018 · 4 comments
Closed

DevTools Error: INVALID_URL when trying to audit extension #6421

eridiniara opened this issue Oct 29, 2018 · 4 comments

Comments

@eridiniara
Copy link

Initial URL: chrome-extension://laookkfknpbbblfpciffpaejjkokdgca/dashboard.html
Chrome Version: 72.0.3590.0
Error Message: INVALID_URL
Stack Trace:

LHError: INVALID_URL
    at lighthouse (chrome-devtools://devtools/remote/serve_file/@ec242826af28a2b3c3b47390ab6141cfe26fe9e7/audits2_worker/audits2_worker_module.js:1130:461)
    at runLighthouseInWorker (chrome-devtools://devtools/remote/serve_file/@ec242826af28a2b3c3b47390ab6141cfe26fe9e7/audits2_worker/audits2_worker_module.js:1570:200)
    at Promise.resolve.then._ (chrome-devtools://devtools/remote/serve_file/@ec242826af28a2b3c3b47390ab6141cfe26fe9e7/audits2_worker/audits2_worker_module.js:4593:133)
@brendankenny
Copy link
Member

This is an interesting case for the url check (in contrast to e.g. #6423). There's no reason that DevTools shouldn't be able to audit an extension's page.

@brendankenny brendankenny changed the title DevTools Error: INVALID_URL DevTools Error: INVALID_URL when trying to audit extension Nov 1, 2018
@patrickhulce
Copy link
Collaborator

Oh yeah that check regressed chrome-extension support for DevTools then :/

@justinribeiro
Copy link
Contributor

That's my bad. I can add chrome-extension: to allowedProtocols and that should resolve it:
https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/lib/url-shim.js#L27

@patrickhulce
Copy link
Collaborator

patrickhulce commented Nov 1, 2018

Yep that should do the trick sounds great! No worries at all @justinribeiro, tbh I completely forgot that DevTools could still audit chrome extensions too until the new errors started popping up 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants