Upgrade puppeteer

[paulirish]

We're rocking a chrome that's a few months old.

Let's bump up to latest!

[wardpeet]

on it!

[wardpeet]

actually we are running on chrome-stable that travis gives us as we skip Puppeteer download. i'll upgrade puppeteer nevertheless
.travis.yml

 # if our e2e tests fail in the future it might be that we are not compatible
  # with the latest puppeteer api so we probably need to run on chromimum
  # @see https://github.com/GoogleChrome/lighthouse/pull/4640/files#r171425004
  - export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1

addons:
  chrome: stable

looking at travis logs we're on chrome 70

Preparing to unpack .../google-chrome-stable_current_amd64.deb ...
Unpacking google-chrome-stable (70.0.3538.77-1) over (62.0.3202.94-1) ...
Setting up google-chrome-stable (70.0.3538.77-1) 

[paulirish]

@wardpeet oh that's true.

well locally we use pptr's chromium, which is a bit old.

[kud]

Hello.

Excuse-me; starting this: npx lighthouse --view --chrome-flags='--headless' runs which browser exactly? My canary? My puppeteer? a puppeteer installed by lighthouse?

backstopjs already installs a puppeteer for me on my project.

[patrickhulce]

@kud this dependency update was just for development dependencies. Lighthouse CLI uses whatever Chrome is found installed on your machine (see https://github.com/GoogleChrome/chrome-launcher/blob/master/src/chrome-finder.ts).

[kud]

Thank you @patrickhulce :)

Do you think it's possible to specify a particular browser like I can do on backstopjs:

engine: "puppeteer",

https://github.com/garris/BackstopJS#chrome-headless-the-latest-webkit-library

[wardpeet]

You can set an environment variable called CHROME_PATH=<path to chrome> on Linux and Mac to set a custom chrome

[kud]

Thank you @wardpeet but it would be applied on any project/tool which needs a chrome, no?

[wardpeet]

Not exactly. Everything that uses Chrome Launcher under the hood would. For example puppeteer doesn't because it has it's own mechanism. You can define a custom path const browser = await puppeteer.launch({executablePath: '/path/to/Chrome'});

[kud]

Oh! Okay, thank you. :)