-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on website doesn't seem to be udpated to v4 #7282
Comments
Here are the PRs those were disabled/removed in:
I assume these were probably meant to be marked in the documentation as deprecated since that's what was done for the WebSQL audit documentation when it was removed. |
@kaycebasques could we deprecate these? @patrickhulce for #2153 it seems like you wanted to do some followup, but I didn't find any discussion on it after this PR. Think we could bring back the checks that this PR removed? |
I meant the checks (against) using old flexbox |
Yeah I'm not sure that audit is really in line with the direction LH has taken over the past 2 years and certainly couldn't pass our new audit guidelines today. If you feel strongly about old flexbox though, by all means I would seriously love to read the questionnaire responses for someone making the case! :D |
~insert Futurama idc meme~ let's keep it dead then. |
@mfriesenhahn is starting to take this over, starting with #9084 |
Lighthouse is currently on v4 but the documentation seemt to talk about v3 (Lighthouse v3 scoring guide). Also there are a few audits that have been disabled in the latest version but are still listed in the website. These are the ones I know of but there might be more:
https://developers.google.com/web/tools/lighthouse/audits/date-now
https://developers.google.com/web/tools/lighthouse/audits/console-time
https://developers.google.com/web/tools/lighthouse/audits/mutation-events
https://developers.google.com/web/tools/lighthouse/audits/old-flexbox
The text was updated successfully, but these errors were encountered: