Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools report redesign #9019

Closed
connorjclark opened this issue May 22, 2019 · 4 comments
Closed

DevTools report redesign #9019

connorjclark opened this issue May 22, 2019 · 4 comments

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented May 22, 2019

I collected some screenshots of what master looks like now in DevTools. Not pretty (yet) :)

This is what 4.2 (in stable) looks like now (yes, DevTools LH had dark mode already):
lh-4 2

Dark mode, master (I zoomed out a lot here):
lh-5 0-before-dark

Light mode, master (same zoom settings as 4.2 img):
lh-5 0-before-light
lh-5 0-before-light-2

--

Dark mode is messed up b/c it was implemented (in DT) with a theme - a bunch of custom CSS overwriting the pre 5.0 stuff. Figure we just need to remove most (or all) of what that theme is doing.

Chromium changes: https://chromium-review.googlesource.com/c/chromium/src/+/1623894

@connorjclark
Copy link
Collaborator Author

Metric error state looks odd w/o an icon:
image

@connorjclark
Copy link
Collaborator Author

connorjclark commented May 22, 2019

Mouse over "Error" in metrics doesn't show the error. Not specific to DT btw.
image

@connorjclark
Copy link
Collaborator Author

Oh, you'd have to toggle the pill meant for metric descriptions to see the error..

@brendankenny
Copy link
Member

fixed! (modulo other open report rendering issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants