Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks don't work for solo category #9058

Closed
connorjclark opened this issue May 25, 2019 · 2 comments · Fixed by #9073
Closed

Fireworks don't work for solo category #9058

connorjclark opened this issue May 25, 2019 · 2 comments · Fixed by #9073

Comments

@connorjclark
Copy link
Collaborator

node lighthouse-cli https://exterkamp.codes --view --only-categories=seo

b/c we do all the fireworks magic in the score header. Which has zero height in solo category mode.

@patrickhulce
Copy link
Collaborator

At one point once upon a time (in the same hue-rotate discussion 😆) we tossed around the idea that fireworks would only happen on all category 100s anyhow, so we might want to do that instead of fixing this? 🤷‍♂

@connorjclark
Copy link
Collaborator Author

ya I could buy that. But in this post-plugin world, who are we to say what constitutes "all" categories? :P

jk, we could do fireworks -> only if 100s on all core categories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants