Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime settings: throttling settings to match the network panel #9380

Closed
andreamoro opened this issue Jul 16, 2019 · 3 comments
Closed

Runtime settings: throttling settings to match the network panel #9380

andreamoro opened this issue Jul 16, 2019 · 3 comments
Assignees

Comments

@andreamoro
Copy link

Feature request summary
Throttling settings to match, or to be extended as per the network panel (giving more flexibility)

What is the motivation or use case for changing this?
Auditing a website often requires multiple pass, and changing the settings in several panels can be daunting but also prone to errors.

Being able to set the network throttling via the "Network panel", and making Lighthouse inheriting the settings would speed us the configuration as well as ensure consistency in the result, which at the moment cannot be guaranteed as the two features are running on parallel non-matching trails.

In an ideal scenario, Lighthouse should get the same settings in the main network panel and use to run the audit.
image

How is this beneficial to Lighthouse?
Flexibility and consistency are the keywords here. This will make the product more robust, but would open up an avenue for you to infer data from different network condition and use to inform the average results.

@connorjclark
Copy link
Collaborator

this will be solved when we implement connection sharing b/wn devtools and lighthouse. see these issues for more: #9095 (comment) #5423

@andreamoro
Copy link
Author

It seems there's quite a few of an overlap, but I'll not exclude to make this as separate point and avoid assumptions

@paulirish
Copy link
Member

In devtools there are multiple bundled throttling presets, plus you can add custom ones.

Technically the throttling we apply uses the same characteristics as the "fast 3g" preset you see in devtools.

We don't want to defer to the current selected devtools throttling preset, as it would mean less consistency from machine to machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants