Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async/await in viewer #9558

Closed
connorjclark opened this issue Aug 14, 2019 · 4 comments · Fixed by #9594
Closed

Support async/await in viewer #9558

connorjclark opened this issue Aug 14, 2019 · 4 comments · Fixed by #9594
Assignees

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Aug 14, 2019

Requires uglify-es >= 3.0.17. we are on 3.0.15.

Will do after #9546.

@connorjclark connorjclark self-assigned this Aug 14, 2019
@wardpeet
Copy link
Collaborator

do we want to move to terser instead? uglify-es isn't activily being worked on. I can pick this up if you like.

@brendankenny
Copy link
Member

if it's a drop-in solution SGTM. I mostly don't want to increase complexity since the only goal is a simple minification, and it would be great to be using something being actively developed.

@wardpeet
Copy link
Collaborator

Yes, it is. I'll create a PR, feel free to throw it away if it's too complex but it's more or less s/uglify-es/terser

@connorjclark
Copy link
Collaborator Author

terser should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants