Runtime Error Design Update

[yuinchien]

[exterkamp]

Note for when we fix this: Fix the i18n of Error for the metrics, and maybe pull the same string?

[paulirish]

thicc bang

[yuinchien]

Here is a zip for the error icons in svg: ic_errors.zip

[rahulpatel596]

@yuinchien I'd like to work on this issue. Just to confirm, its simply to update all current error icons with new design in lighthouse performance report, Right?
Not sure about second error with i18n error, but might just get started first.. 😄

[patrickhulce]

Thanks @rahulpatel596! Basically.

We want to replace the red triangle with the new red exclamation icon for all audits that error.

Sidenote for Lighthouse team, what do you think about changing the text from "Error" to "Exception Thrown"? I feel like that might clear up most of the confusion around whether this is their failure or ours.

[rahulpatel596]

Hey @patrickhulce
I am working on this and I just wanted to confirm that I am making changes in correct place because current production version has a quite different UI.
Thanks for your help :)

[patrickhulce]

We don't want to replace the legend one, other than that yes those 3 places would have the exclamation instead of the question mark/triangle and the regular audits below this as well. Keep in mind that this exclamation design should only apply when there has been an error and the score is null.

[rahulpatel596]

Hey @patrickhulce Is there a specific method or way to follow which can generate report with an error and/or with null score?

[patrickhulce]

Yes @rahulpatel596, every PR has a sample error report deployed and you can replicate it on your local machine with yarn now-build

[patrickhulce]

Some good progress was made in #11670 but this is available again if anyone would like to pick it up.

[tannerdolby]

I'm happy to work on this, but it seems there is already a PR (#9272) that handles updating the error icons.

[adamraine]

@tannerdolby that PR is very old, you are welcome to submit your own :)

[tannerdolby]

@adamraine sounds good, I will start working on this and submit a PR soon :)