From 47a9a63827c74e3508e880d9578a24ea13ea49b0 Mon Sep 17 00:00:00 2001 From: Aviad Reich Date: Thu, 4 Oct 2018 10:54:23 +0300 Subject: [PATCH] core(audit): add utm parameters when calling snyk --- lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js | 2 +- .../test/audits/dobetterweb/no-vulnerable-libraries-test.js | 2 +- lighthouse-core/test/results/sample_v2.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js b/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js index eec3543fff40..cfa7fdf4b8ff 100644 --- a/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js +++ b/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js @@ -153,7 +153,7 @@ class NoVulnerableLibrariesAudit extends Audit { vulnCount, detectedLib: { text: lib.name + '@' + version, - url: `https://snyk.io/vuln/npm:${lib.npmPkgName}?lh=${version}`, + url: `https://snyk.io/vuln/npm:${lib.npmPkgName}?lh=${version}&utm_source=lighthouse&utm_medium=ref&utm_campaign=audit`, type: 'link', }, }); diff --git a/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js b/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js index c225d7272624..6c9151c61572 100644 --- a/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js +++ b/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js @@ -40,7 +40,7 @@ describe('Avoids front-end JavaScript libraries with known vulnerabilities', () assert.equal(auditResult.details.items[0].highestSeverity, 'High'); assert.equal(auditResult.details.items[0].detectedLib.type, 'link'); assert.equal(auditResult.details.items[0].detectedLib.text, 'angular@1.1.4'); - assert.equal(auditResult.details.items[0].detectedLib.url, 'https://snyk.io/vuln/npm:angular?lh=1.1.4'); + assert.equal(auditResult.details.items[0].detectedLib.url, 'https://snyk.io/vuln/npm:angular?lh=1.1.4&utm_source=lighthouse&utm_medium=ref&utm_campaign=audit'); }); it('handles ill-specified versions', () => { diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 7451b200a3b7..9c93ce33baf6 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -2376,7 +2376,7 @@ "vulnCount": 1, "detectedLib": { "text": "jQuery@2.1.1", - "url": "https://snyk.io/vuln/npm:jquery?lh=2.1.1", + "url": "https://snyk.io/vuln/npm:jquery?lh=2.1.1&utm_source=lighthouse&utm_medium=ref&utm_campaign=audit", "type": "link" } }