From 3c2abd1819afdbd15580e475d069f40a63b5f456 Mon Sep 17 00:00:00 2001 From: Stefano Chiodino Date: Mon, 11 Mar 2019 07:12:23 +0000 Subject: [PATCH] Wrap HTMl in markdown code I noticed the link tag was being rendered as actual HTML in my application, needs to be escaped! --- lighthouse-core/audits/uses-rel-preload.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-core/audits/uses-rel-preload.js b/lighthouse-core/audits/uses-rel-preload.js index 671e2ffea579..fb198c312142 100644 --- a/lighthouse-core/audits/uses-rel-preload.js +++ b/lighthouse-core/audits/uses-rel-preload.js @@ -18,10 +18,10 @@ const UIStrings = { /** Imperative title of a Lighthouse audit that tells the user to use to initiate important network requests earlier during page load. This is displayed in a list of audit titles that Lighthouse generates. */ title: 'Preload key requests', /** Description of a Lighthouse audit that tells the user *why* they should preload important network requests. The associated network requests are started halfway through pageload (or later) but should be started at the beginning. This is displayed after a user expands the section to see more. No character length limits. '' is the html code the user would include in their page and shouldn't be translated. 'Learn More' becomes link text to additional documentation. */ - description: 'Consider using to prioritize fetching resources that are ' + + description: 'Consider using `` to prioritize fetching resources that are ' + 'currently requested later in page load. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/preload).', /** A warning message that is shown when the user tried to follow the advice of the audit, but it's not working as expected. Forgetting to set the `crossorigin` HTML attribute, or setting it to an incorrect value, on the link is a common mistake when adding preload links. */ - crossoriginWarning: 'A preload was found for "{preloadURL}" but was not used ' + + crossoriginWarning: 'A preload `` was found for "{preloadURL}" but was not used ' + 'by the browser. Check that you are using the `crossorigin` attribute properly.', };