From 2b70bf5293bf4bb97f4e9be70f841a5821ce6a0b Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Thu, 30 May 2019 01:30:03 -0700 Subject: [PATCH] devtools: do not query system preferences for dark mode --- lighthouse-core/report/html/renderer/report-ui-features.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lighthouse-core/report/html/renderer/report-ui-features.js b/lighthouse-core/report/html/renderer/report-ui-features.js index b403805b5610..612ba1a3e4dd 100644 --- a/lighthouse-core/report/html/renderer/report-ui-features.js +++ b/lighthouse-core/report/html/renderer/report-ui-features.js @@ -92,7 +92,9 @@ class ReportUIFeatures { topbarLogo.addEventListener('click', () => this._toggleDarkTheme()); let turnOffTheLights = false; - if (window.matchMedia('(prefers-color-scheme: dark)').matches) { + // Do not query the system preferences for DevTools - DevTools should only apply dark theme + // if dark is selected in the settings panel. + if (!this._dom.isDevTools() && window.matchMedia('(prefers-color-scheme: dark)').matches) { turnOffTheLights = true; }