From 57e18251e7ad79af03b67c58d6935550f4b1bea8 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Mon, 24 Jun 2019 18:53:06 +0530 Subject: [PATCH 1/3] switch to open closes #9265 --- lighthouse-cli/run.js | 4 ++-- package.json | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lighthouse-cli/run.js b/lighthouse-cli/run.js index cc8c717f1995..8574e2342743 100644 --- a/lighthouse-cli/run.js +++ b/lighthouse-cli/run.js @@ -18,7 +18,7 @@ const log = require('lighthouse-logger'); const getFilenamePrefix = require('../lighthouse-core/lib/file-namer.js').getFilenamePrefix; const assetSaver = require('../lighthouse-core/lib/asset-saver.js'); -const opn = require('opn'); +const open = require('open'); /** @typedef {import('../lighthouse-core/lib/lh-error.js')} LighthouseError */ @@ -138,7 +138,7 @@ async function saveResults(runnerResult, flags) { if (outputType === Printer.OutputMode[Printer.OutputMode.html]) { if (flags.view) { - opn(outputPath, {wait: false}); + open(outputPath, {wait: false}); } else { // eslint-disable-next-line max-len log.log('CLI', 'Protip: Run lighthouse with `--view` to immediately open the HTML report in your browser'); diff --git a/package.json b/package.json index 8598a456b899..22838fc6f1de 100644 --- a/package.json +++ b/package.json @@ -85,7 +85,6 @@ "@types/make-dir": "^1.0.3", "@types/mkdirp": "^0.5.2", "@types/node": "*", - "@types/opn": "^3.0.28", "@types/raven": "^2.5.1", "@types/resize-observer-browser": "^0.1.1", "@types/rimraf": "^2.0.2", @@ -153,7 +152,7 @@ "lookup-closest-locale": "6.0.4", "metaviewport-parser": "0.2.0", "mkdirp": "0.5.1", - "opn": "4.0.2", + "open": "^6.3.0", "parse-cache-control": "1.0.1", "raven": "^2.2.1", "rimraf": "^2.6.1", From 1406ac758106ca12c9fbc0fa520f3d0abd167238 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Mon, 24 Jun 2019 19:07:12 +0530 Subject: [PATCH 2/3] Update docs update reference of opn to open --- docs/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/readme.md b/docs/readme.md index 0cd05d05771a..a397dbd5a452 100644 --- a/docs/readme.md +++ b/docs/readme.md @@ -58,7 +58,7 @@ Note that some flag functionality is only available to the CLI. The set of share | `chromeFlags` | Ignored, Chrome is not launched for you. | | `outputPath` | Ignored, output is returned as string in `.report` property. | | `saveAssets` | Ignored, artifacts are returned in `.artifacts` property. | -| `view` | Ignored, use the `opn` npm module if you want this functionality. | +| `view` | Ignored, use the `open` npm module if you want this functionality. | | `enableErrorReporting` | Ignored, error reporting is always disabled for node. | | `listAllAudits` | Ignored, not relevant in programmatic use. | | `listTraceCategories` | Ignored, not relevant in programmatic use. | From 1a49c3d8c4785fc5d02051adeeaf2ab461d53677 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 13 Jul 2019 11:04:31 +0530 Subject: [PATCH 3/3] yarn.lock --- package.json | 2 +- yarn.lock | 18 +++++------------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/package.json b/package.json index 22838fc6f1de..5f6310371a1f 100644 --- a/package.json +++ b/package.json @@ -152,7 +152,7 @@ "lookup-closest-locale": "6.0.4", "metaviewport-parser": "0.2.0", "mkdirp": "0.5.1", - "open": "^6.3.0", + "open": "^6.4.0", "parse-cache-control": "1.0.1", "raven": "^2.2.1", "rimraf": "^2.6.1", diff --git a/yarn.lock b/yarn.lock index 0513c49eeb75..639ccc51a41b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -570,13 +570,6 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-10.14.0.tgz#1c297530428c6f4e0a0a3222f5b44745669aa9f7" integrity sha512-1UhSMMDix7bVdUeqtZERQQyJr3QuFoN5X5APtpIooGkumE3crPaeq7UgFeJNjGD8yCQ8od8PzRkgptR5+x327Q== -"@types/opn@^3.0.28": - version "3.0.28" - resolved "https://registry.yarnpkg.com/@types/opn/-/opn-3.0.28.tgz#097d0d1c9b5749573a5d96df132387bb6d02118a" - integrity sha1-CX0NHJtXSVc6XZbfEyOHu20CEYo= - dependencies: - "@types/node" "*" - "@types/raven@^2.5.1": version "2.5.1" resolved "https://registry.yarnpkg.com/@types/raven/-/raven-2.5.1.tgz#62ef0a59e29691945e1f295b62ed199619cbd9b6" @@ -5706,13 +5699,12 @@ onetime@^2.0.0: dependencies: mimic-fn "^1.0.0" -opn@4.0.2: - version "4.0.2" - resolved "https://registry.yarnpkg.com/opn/-/opn-4.0.2.tgz#7abc22e644dff63b0a96d5ab7f2790c0f01abc95" - integrity sha1-erwi5kTf9jsKltWrfyeQwPAavJU= +open@^6.4.0: + version "6.4.0" + resolved "https://registry.yarnpkg.com/open/-/open-6.4.0.tgz#5c13e96d0dc894686164f18965ecfe889ecfc8a9" + integrity sha512-IFenVPgF70fSm1keSd2iDBIDIBZkroLeuffXq+wKTzTJlBpesFWojV9lb8mzOfaAzM1sr7HQHuO0vtV0zYekGg== dependencies: - object-assign "^4.0.1" - pinkie-promise "^2.0.0" + is-wsl "^1.1.0" optimist@^0.6.1: version "0.6.1"