From eb582bacc48f346bd7514c52d1f812d3e5511191 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Mon, 26 Aug 2019 15:38:55 -0700 Subject: [PATCH] updated wording of description to be more clear. --- lighthouse-core/audits/manual/pwa-page-transitions.js | 4 ++-- lighthouse-core/lib/i18n/locales/en-US.json | 2 +- lighthouse-core/lib/i18n/locales/en-XL.json | 2 +- lighthouse-core/test/results/sample_v2.json | 2 +- proto/sample_v2_round_trip.json | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lighthouse-core/audits/manual/pwa-page-transitions.js b/lighthouse-core/audits/manual/pwa-page-transitions.js index b95fc3fb2591..401ef2cc1702 100644 --- a/lighthouse-core/audits/manual/pwa-page-transitions.js +++ b/lighthouse-core/audits/manual/pwa-page-transitions.js @@ -12,8 +12,8 @@ const UIStrings = { /** Title of a Lighthouse audit that prompts the user to manually check that page transitions (navigating to other pages on a website) shouldn't feel like they are waiting for the network to load. */ title: 'Page transitions don\'t feel like they block on the network', /** Description of a Lighthouse audit that tells the user why they should make transitions in their web app feel fast. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ - description: 'Transitions should feel snappy as you tap around, even on a slow network, a ' + - 'key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions).', + description: 'Transitions should feel snappy as you tap around, even on a slow network. ' + + 'This experience is key to a user\'s perception of performance. [Learn more](https://web.dev/pwa-page-transitions).', }; const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); diff --git a/lighthouse-core/lib/i18n/locales/en-US.json b/lighthouse-core/lib/i18n/locales/en-US.json index 434da05731c0..67e13c4bd767 100644 --- a/lighthouse-core/lib/i18n/locales/en-US.json +++ b/lighthouse-core/lib/i18n/locales/en-US.json @@ -771,7 +771,7 @@ "message": "Each page has a URL" }, "lighthouse-core/audits/manual/pwa-page-transitions.js | description": { - "message": "Transitions should feel snappy as you tap around, even on a slow network, a key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions)." + "message": "Transitions should feel snappy as you tap around, even on a slow network. This experience is key to a user's perception of performance. [Learn more](https://web.dev/pwa-page-transitions)." }, "lighthouse-core/audits/manual/pwa-page-transitions.js | title": { "message": "Page transitions don't feel like they block on the network" diff --git a/lighthouse-core/lib/i18n/locales/en-XL.json b/lighthouse-core/lib/i18n/locales/en-XL.json index 8eb5f0363288..cb9cd79ac03c 100644 --- a/lighthouse-core/lib/i18n/locales/en-XL.json +++ b/lighthouse-core/lib/i18n/locales/en-XL.json @@ -771,7 +771,7 @@ "message": "Êáĉh́ p̂áĝé ĥáŝ á ÛŔL̂" }, "lighthouse-core/audits/manual/pwa-page-transitions.js | description": { - "message": "T̂ŕâńŝít̂íôńŝ śĥóûĺd̂ f́êél̂ śn̂áp̂ṕŷ áŝ ýôú t̂áp̂ ár̂óûńd̂, év̂én̂ ón̂ á ŝĺôẃ n̂ét̂ẃôŕk̂, á k̂éŷ t́ô ṕêŕĉéîv́êd́ p̂ér̂f́ôŕm̂án̂ćê. [Ĺêár̂ń m̂ór̂é](https://web.dev/pwa-page-transitions)." + "message": "T̂ŕâńŝít̂íôńŝ śĥóûĺd̂ f́êél̂ śn̂áp̂ṕŷ áŝ ýôú t̂áp̂ ár̂óûńd̂, év̂én̂ ón̂ á ŝĺôẃ n̂ét̂ẃôŕk̂. T́ĥíŝ éx̂ṕêŕîén̂ćê íŝ ḱêý t̂ó â úŝér̂'ś p̂ér̂ćêṕt̂íôń ôf́ p̂ér̂f́ôŕm̂án̂ćê. [Ĺêár̂ń m̂ór̂é](https://web.dev/pwa-page-transitions)." }, "lighthouse-core/audits/manual/pwa-page-transitions.js | title": { "message": "P̂áĝé t̂ŕâńŝít̂íôńŝ d́ôń't̂ f́êél̂ ĺîḱê t́ĥéŷ b́l̂óĉḱ ôń t̂h́ê ńêt́ŵór̂ḱ" diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 439118178a85..3cd6fd23b7dd 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -1535,7 +1535,7 @@ "pwa-page-transitions": { "id": "pwa-page-transitions", "title": "Page transitions don't feel like they block on the network", - "description": "Transitions should feel snappy as you tap around, even on a slow network, a key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions).", + "description": "Transitions should feel snappy as you tap around, even on a slow network. This experience is key to a user's perception of performance. [Learn more](https://web.dev/pwa-page-transitions).", "score": null, "scoreDisplayMode": "manual" }, diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index a1d894a6dcd8..ea91601c4f4d 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -2184,7 +2184,7 @@ "title": "Each page has a URL" }, "pwa-page-transitions": { - "description": "Transitions should feel snappy as you tap around, even on a slow network, a key to perceived performance. [Learn more](https://web.dev/pwa-page-transitions).", + "description": "Transitions should feel snappy as you tap around, even on a slow network. This experience is key to a user's perception of performance. [Learn more](https://web.dev/pwa-page-transitions).", "id": "pwa-page-transitions", "score": null, "scoreDisplayMode": "manual",