Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix Matcher.toEqual to not depend on key insertion order #2091

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

aslushnikov
Copy link
Contributor

Objects {foo: 1, bar: 2} and {bar: 2, foo: 1} should be considered
equal.

Objects `{foo: 1, bar: 2}` and `{bar: 2, foo: 1}` should be considered
equal.
Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you hit this somewhere? Key order is detectable, so maybe we should leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants