Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unload event listeners should not be used #67

Closed
philipwalton opened this issue Jul 24, 2020 · 0 comments · Fixed by #68
Closed

Unload event listeners should not be used #67

philipwalton opened this issue Jul 24, 2020 · 0 comments · Fixed by #68
Assignees
@philipwalton

Comments

@philipwalton
Copy link
Member

Given the new no-unload-listeners audit that's been added to Lighthouse, we should remove any use of the unload event. Even though the use in this library is to fix a bug and doesn't apply to the issues described in the audit, we still don't want sites to fail the audit because of this library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipwalton philipwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the unload listener GoogleChrome/web-vitals
1 participant
@philipwalton