Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

content: Tidy PWA Lighthouse audit posts #1343

Closed
5 of 8 tasks
mfriesenhahn opened this issue Aug 15, 2019 · 11 comments · Fixed by #1587
Closed
5 of 8 tasks

content: Tidy PWA Lighthouse audit posts #1343

mfriesenhahn opened this issue Aug 15, 2019 · 11 comments · Fixed by #1587
Assignees
Labels
content Issues related to content P0 An urgent priority task. Drop everything and work on this!

Comments

@mfriesenhahn
Copy link
Contributor

mfriesenhahn commented Aug 15, 2019

Author: @mfriesenhahn
Reviewer: @kaycebasques

Target publish date:

  • Check this box if this is a hard deadline.

  • Check this box if you'd like your reviewer to fix grammar and punctuation issues for you.

Process

Check out the web.dev writing process.

When you're ready, make a copy of this template
and fill in the proposal and outline sections. When you're finished, drop a link
to the doc in the 1st step below and check the box. A member of the web.dev team
will assign this ticket to themselves and work as your reviewer to help you
complete the remaining steps.

  • 1. I've done my proposal
  • 2. Proposal approved — reviewer checks this
  • 3. I've added a draft to my proposal doc
  • 4. Draft approved — reviewer checks this
  • 5. I've submitted a pull request Lighthouse PWA audit post updates #1587
  • 6. Pull request approved — reviewer checks this
@mfriesenhahn mfriesenhahn added the content Issues related to content label Aug 15, 2019
@mfriesenhahn mfriesenhahn self-assigned this Aug 15, 2019
@mfriesenhahn mfriesenhahn added this to the Sprint 2019-08-28 milestone Aug 15, 2019
@carolrivero carolrivero added the P0 An urgent priority task. Drop everything and work on this! label Aug 15, 2019
@mfriesenhahn
Copy link
Contributor Author

Comments from @patrickhulce, originally on Lighthouse PR 9539:

  • The /redirects-http doc seems to give the opposite advice, we want them to redirect their http traffic to https and the doc is mostly talking about avoiding redirects.
  • Do we plan to move the PWA checklist over?

@kaycebasques
Copy link
Contributor

No updates.

@webby-probot webby-probot bot added the writing label Sep 16, 2019
@kaycebasques
Copy link
Contributor

The scope of this PR is to normalize the content. We'll do a more thorough review of the content in a subsequent PR.

@kaycebasques
Copy link
Contributor

Status: Normalization is done. Michael is fixing some docs that aren't talking about what the audit is actually measuring.

@mfriesenhahn
Copy link
Contributor Author

Both normalization and quality work complete. Ready for @kaycebasques to review.

Note: I didn't add content where it might be helpful because I didn't want to step out of scope, but there are some posts that are very slim. Most immediately, /pwa-cross-browser.

@kaycebasques
Copy link
Contributor

@kaycebasques to do a tech writer review, there's an open question around heading wording. Look at redirects post and redirects HTTPS posts. These were re-written.

Michael did quality fixes too

FYI Rob checked consistency of normalization, skimmed content, mostly looking for normalization stuff

@kaycebasques
Copy link
Contributor

Done! Woohoo! Off to @robdodson to publish.

@mfriesenhahn
Copy link
Contributor Author

@kaycebasques, you introduced a title error when you committed your changes. See PR for details.

@mfriesenhahn mfriesenhahn reopened this Oct 3, 2019
@webby-probot webby-probot bot added code review and removed done labels Oct 3, 2019
@kaycebasques
Copy link
Contributor

Thanks @mfriesenhahn for fixing my goof, off to @robdodson to publish

@robdodson
Copy link
Contributor

it's uuuuuup

@webby-probot webby-probot bot added done and removed code review labels Oct 9, 2019
@github-actions
Copy link

github-actions bot commented Oct 9, 2019

@kaycebasques, remember to send the feedback survey!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content Issues related to content P0 An urgent priority task. Drop everything and work on this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants