[BUG] The partial_implementation field is not taken into account

[bramus]

This is a follow-up to #996 about popover that was Baseline, but then not, but now is.

The reason why the feature was initially considered to be Baseline is because the partial_implementation field was ignored.

Before mdn/browser-compat-data#25787 which marks the features a included in Safari iOS 18.3, the data looked like this:

            "safari_ios": {
              "version_added": "17",
              "partial_implementation": true,
              "notes": "On iOS and iPadOS, popovers are not dismissed when the user taps outside of the popover area, see [bug 267688](https://webkit.org/b/267688)."
            },

Had the partial_implementation field been taken into account, the feature would never have been marked as Baseline Newly Available.

[jcscottiii]

Thanks for calling that out.

The calculation for baseline happens in https://github.com/web-platform-dx/web-features. Here's the file specifically for popover. We just read the compiled data from there.

https://github.com/web-platform-dx/web-features/tree/b44c75ca30a98706bcfbc61225b51fde3c5b4db5/packages/compute-baseline

Could you make the issue there?

@ddbeck I see there is a check for partial implementation in the Web features code. But do you know what happened?

[jcscottiii]

Also, we have another issue about popover specifically here. That may have some more context for you @bramus

[bramus]

Thanks for the extra info. I have left a reply on web-platform-dx/web-features#915 which I think deals with this.

[ddbeck]

@jcscottiii Thanks for mentioning me on this. I've taken this up in the web-features conversation, but in case anyone else comes across this here and wants the summary:

The computation in web-features is correct, but the underlying information in browser compat data changed over time, first correcting a mistake (showing full support) then later reflecting the fix in Safari.