You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While making some updates to the Workbox tests, I noticed that the test added in #2136 for update() do not actually test the update behavior (I missed this in the PR review):
There should only ever be one registration instance per scope, so this test shouldn't be asserting calling update() returns a new object. It's only passing here because update() is returning Promise<void> rather than a registration.
The text was updated successfully, but these errors were encountered:
Library Affected:
workbox-window
While making some updates to the
Workbox
tests, I noticed that the test added in #2136 forupdate()
do not actually test the update behavior (I missed this in the PR review):workbox/test/workbox-window/window/test-Workbox.mjs
Lines 292 to 301 in ae80e39
There should only ever be one registration instance per scope, so this test shouldn't be asserting calling
update()
returns a new object. It's only passing here becauseupdate()
is returningPromise<void>
rather than a registration.The text was updated successfully, but these errors were encountered: