Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strict: true tsc option #2242

Closed
jeffposnick opened this issue Oct 3, 2019 · 0 comments · Fixed by #2244
Closed

Use strict: true tsc option #2242

jeffposnick opened this issue Oct 3, 2019 · 0 comments · Fixed by #2244
Assignees
@jeffposnick
Labels
Infrastructure Related to the helper and utility scripts in the project.
Milestone
v5

Comments

@jeffposnick
Copy link
Contributor

#2241 enables strictPropertyInitialization, but we would have had that enabled already if we went with the "strict": true compiler option.

It's probably a good idea to flip that on and remediate all the problems (in a separate PR).
@jeffposnick jeffposnick added the Infrastructure Related to the helper and utility scripts in the project. label Oct 3, 2019
@jeffposnick jeffposnick self-assigned this Oct 4, 2019
@jeffposnick jeffposnick mentioned this issue Oct 4, 2019
Merged
@jeffposnick jeffposnick added this to the v5 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffposnick jeffposnick

Labels
Infrastructure Related to the helper and utility scripts in the project.
Projects
None yet
Milestone
v5
Development

Successfully merging a pull request may close this issue.

Strict TypeScript cleanup GoogleChrome/workbox
1 participant
@jeffposnick