Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to run gulp build before test #2628

Closed
piotr-cz opened this issue Sep 10, 2020 · 0 comments · Fixed by #2629
Closed

Add instructions to run gulp build before test #2628

piotr-cz opened this issue Sep 10, 2020 · 0 comments · Fixed by #2629

Comments

@piotr-cz
Copy link
Contributor

Library Affected:
none

Browser & Platform:
none

Issue or Feature Request Description:
Your request here.

GitHub PR template says

ensure that gulp lint test passes locally.

However it doesn't say that for gulp test it's required to install packages/* dependencies via gulp build command.
Also in the CONTRIBUTING.md file there are no such instructions.

I suggest to rephrase it one of these:

  • ensure that gulp build && gulp lint test passes locally.
  • ensure that gulp build gulp lint test --series passes locally.
  • ensure that gulp lint test --series passes locally (run gulp build to install dependencies first).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant