Skip to content

Commit

Permalink
[infra] Fix tests (#142)
Browse files Browse the repository at this point in the history
  • Loading branch information
addyosmani authored Nov 27, 2019
1 parent d5d5ca5 commit 6644860
Show file tree
Hide file tree
Showing 4 changed files with 1,522 additions and 1,388 deletions.
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,22 @@
},
"devDependencies": {
"babel-preset-env": "^1.7.0",
"bundlesize": "^0.17.0",
"bundlesize": "^0.18.0",
"chai": "^4.2.0",
"conventional-changelog-cli": "^2.0.11",
"cross-var": "^1.1.0",
"eslint": "^5.9.0",
"eslint-config-google": "^0.11.0",
"http-server": "^0.11.1",
"eslint": "^6.7.1",
"eslint-config-google": "^0.14.0",
"http-server": "^0.12.0",
"lodash": "^4.17.11",
"microbundle": "^0.9.0",
"mocha": "^5.2.0",
"puppeteer": "^1.10.0"
"microbundle": "0.11.0",
"mocha": "^6.2.2",
"puppeteer": "^2.0.0"
},
"bundlesize": [
{
"path": "./dist/*.js",
"maxSize": "2 kB"
}
]
}
}
6 changes: 3 additions & 3 deletions test/quicklink.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('quicklink tests', function () {
expect(responseURLs).to.be.an('array');
// => origins: true
expect(responseURLs).to.include(`${server}/2.html`);
expect(responseURLs).to.include('https://foobar.com/3.html');
expect(responseURLs).to.include('https://example.com/3.html');
expect(responseURLs).to.include('https://example.com/1.html');
expect(responseURLs).to.include('https://github.githubassets.com/images/spinners/octocat-spinner-32.gif');
});
Expand Down Expand Up @@ -194,7 +194,7 @@ describe('quicklink tests', function () {
// don't care about first 4 URLs (markup)
const ours = responseURLs.slice(4);

expect(ours.length).to.equal(1);
expect(ours.length).to.equal(2);
expect(ours).to.include(`${server}/2.html`);
});

Expand Down Expand Up @@ -222,7 +222,7 @@ describe('quicklink tests', function () {
// don't care about first 4 URLs (markup)
const ours = responseURLs.slice(4);

expect(ours.length).to.equal(1);
expect(ours.length).to.equal(2);
expect(ours).to.include(`${server}/1.html`);
});

Expand Down
4 changes: 2 additions & 2 deletions test/test-allow-origin-all.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<body>
<a href="https://example.com/1.html">Link 1</a>
<a href="2.html">Link 2</a>
<a href="https://foobar.com/3.html">Link 3</a>
<a href="https://example.com/3.html">Link 3</a>
<a href="https://github.githubassets.com/images/spinners/octocat-spinner-32.gif">Spinner</a>
<section id="stuff">
<a href="main.css">CSS</a>
Expand All @@ -27,4 +27,4 @@
</script>
</body>

</html>
</html>
Loading

0 comments on commit 6644860

Please sign in to comment.