Bugfix/syntax highlighting site #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anton-karlovskiy
commented
Dec 3, 2019
•
anton-karlovskiy
commented
- highlight.js is up-to-date (v9.16.2) so some broken syntax highlighting is fixed by upgrading the lib
- syntax highlighting is restored
- linked CDN css for syntax highlighting and removed local css file
|
Thanks! |
|
Hmm. I need to dig into this further when not on mobile, but it looks like our latest deploys are having challenges with syntax highlighting again (this fix was included). I'll debug later in the day, but just wanted to highlight this. |
|
Let me debug it too. |
|
On my side, I think syntax-highlighting looks okay. |
|
Hey Anton. After retesting syntax highlighting on the current deployment it does appear to be working. I'll chalk up my previous tests to there being a caching issue of some sort :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.