Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-prefetching section for home page #148

Merged
merged 3 commits into from
Dec 7, 2019

Conversation

demianrenzulli
Copy link
Contributor

Section covering techniques to avoid over-prefetching with Quicklink.

{% markdownConvert %}
```js
quicklink.listen({
el: document.getElementById('carousel')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about us using an example like document.getElementById('article') or document.getElementById('content')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to 'content', thank you!

@addyosmani
Copy link
Collaborator

I think these changes strike the right balance of conveying how our latest features for limiting and controlling throttling help avoid the over-prefetching problem well.

I like that we started off with sharing how to limit prefetching to specific elements. Something I may try doing if there's time is creating a nice SVG that shows how this works.

But overall I think this will help. Going ahead and landing the change 👍

@addyosmani addyosmani merged commit 75aa643 into GoogleChromeLabs:master Dec 7, 2019
@demianrenzulli
Copy link
Contributor Author

Great! Thanks @addyosmani. I tested both option parameters on the demo site (limit and throttling), and could visualize clearly in the network tab how in one case requests are limited to a certain number and, in the other, how they are sent sequentially instead of simultaneously.

With that said, if at some point think we would need a demo to complement this explanation, it can be easily done as well. 👍

demianrenzulli added a commit to demianrenzulli/quicklink that referenced this pull request Dec 10, 2019
[docs] Over-prefetching section for home page (GoogleChromeLabs#148)
demianrenzulli added a commit to demianrenzulli/quicklink that referenced this pull request Dec 10, 2019
[docs] Over-prefetching section for home page (GoogleChromeLabs#148)

* Home section around over-prefetching.

* Over-prefetching partial.

* Changing carousel by content.

Quicklink Chrome extension section for home page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants