-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding React SPA demos to repo and site #179
Conversation
[docs] Over-prefetching section for home page (GoogleChromeLabs#148)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Do you know why there's a string identifier before api.glitch.com in git clone https://[email protected]/git/create-react-app-quicklink?
Good question, Addy. I've noticed that also (unlike the links the other demos). I created that link by going to Tools->Import and Export->Git URL. The tool doesn't let me edit the URL. I'm wondering if you did something different for the other demos, or perhaps Glitch has changed the way it generates the URLs lately? Alternatively we can use the URL of my repo: git clone [email protected]:demianrenzulli/create-react-app-unejected-quicklink.git Any ideas are welcome! |
@demianrenzulli cc @addyosmani Could you please try |
Thanks @anton-karlovskiy! Removing the hash that Glitch generates seems to just work 👍 Changed it to the new URL. |
Thank you for these additions folks! |
cc // @addyosmani @anton-karlovskiy