-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to specify arbitrary arguments to devappserver #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 65.65% 65.79% +0.13%
==========================================
Files 64 64
Lines 1779 1789 +10
Branches 277 280 +3
==========================================
+ Hits 1168 1177 +9
Misses 489 489
- Partials 122 123 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if someone passes a known argument as an additional argument? Or if someone passes the same argument in both?
The behaviour is up to the devappserver. The additional arguments are appended at the end, before the app directories / service files. I imagine this will only be used to add items that we don't have any UI to manage. |
Any concerns @loosebazooka? |
Oh oops, I was supposed to look at this. I'll do it right now. |
ping @loosebazooka ? |
Oh sorry again. |
Fixes #432