Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify arbitrary arguments to devappserver #433

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

briandealwis
Copy link
Member

Fixes #432

@codecov-io
Copy link

codecov-io commented Jul 7, 2017

Codecov Report

Merging #433 into master will increase coverage by 0.13%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   65.65%   65.79%   +0.13%     
==========================================
  Files          64       64              
  Lines        1779     1789      +10     
  Branches      277      280       +3     
==========================================
+ Hits         1168     1177       +9     
  Misses        489      489              
- Partials      122      123       +1
Impacted Files Coverage Δ
...ppengine/cloudsdk/CloudSdkAppEngineDevServer1.java 87.3% <100%> (+0.3%) ⬆️
...ppengine/cloudsdk/CloudSdkAppEngineDevServer2.java 69.35% <100%> (+1.55%) ⬆️
...pengine/api/devserver/DefaultRunConfiguration.java 97.5% <75%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f57286...c7a369c. Read the comment docs.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if someone passes a known argument as an additional argument? Or if someone passes the same argument in both?

@briandealwis
Copy link
Member Author

The behaviour is up to the devappserver. The additional arguments are appended at the end, before the app directories / service files.

I imagine this will only be used to add items that we don't have any UI to manage.

@loosebazooka loosebazooka self-requested a review July 10, 2017 19:35
@briandealwis
Copy link
Member Author

Any concerns @loosebazooka?

@loosebazooka
Copy link
Contributor

Oh oops, I was supposed to look at this. I'll do it right now.

@briandealwis
Copy link
Member Author

ping @loosebazooka ?

@loosebazooka
Copy link
Contributor

Oh sorry again.

@briandealwis briandealwis merged commit 15a4709 into master Jul 13, 2017
@briandealwis briandealwis deleted the i432 branch July 13, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants