Skip to content
This repository was archived by the owner on Apr 2, 2023. It is now read-only.

Generalize Google JSON client configurations #81

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Generalize Google JSON client configurations #81

merged 1 commit into from
Feb 24, 2021

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Feb 24, 2021

Use GraalVM reachability hooks for JSON client classes, which allows us to avoid having to hardcode class names for Apiary libraries.

@dzou dzou requested a review from a team February 24, 2021 18:00
elefeint
elefeint approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+24 −115 -- best kind of code change.

@dzou
Copy link
Contributor Author

dzou commented Feb 24, 2021

+24 −115 -- best kind of code change.

Yup :)

@dzou dzou merged commit 678fb23 into master Feb 24, 2021
@dzou dzou deleted the json-generalized branch February 24, 2021 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elefeint elefeint elefeint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzou @elefeint