feat: add ability to periodically request debug headers #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorbernstein2
force-pushed
the
debug-headers2
branch
from
26dfe1b to
bf1edc4
Compare
|
/gcbrun |
nimf
reviewed
Apr 5, 2022
| @@ -152,6 +153,11 @@ export = (grpc: GrpcModule) => { | |||
| : []; | |||
| newCallOptions.interceptors = interceptors.concat([postProcessInterceptor]); | |||
|
|
|||
| if (channelFactory.shouldRequestDebugHeaders(channelRef.getDebugHeadersRequestedAt())) { | |||
| metadata.set('x-return-encrypted-headers', 'all_response'); | |||
There was a problem hiding this comment.
I thought we wanted to use 'true' here?
There was a problem hiding this comment.
I decided to include the afe headers as well
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is opt-in by setting debug_header_interval_secs in the ApiConfig:
-1will requests debug headers for every RPCThe response headers can be examined in verbose grpc logs. The contents will be encrypted and will only be viewable by a google engineer