Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Cleanup InitIgnoreList(detectFilesystem bool) #2840

Closed
aaron-prindle opened this issue Nov 11, 2023 · 0 comments · Fixed by #2843
Closed

[refactor] Cleanup InitIgnoreList(detectFilesystem bool) #2840

aaron-prindle opened this issue Nov 11, 2023 · 0 comments · Fixed by #2843
Labels
good first issue Good for newcomers help wanted Looking for a volunteer! kind/enhancement New feature or request meta/kaniko priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@aaron-prindle
Copy link
Collaborator

Currently func InitIgnoreList(detectFilesystem bool) error { takes ini a bool parameter but in all code, the value is only ever set to true. This issue tracks removing the bool parameter as it is unused:

Related code:
https://github.com/GoogleContainerTools/kaniko/blob/main/pkg/util/fs_util.go#L1035
@aaron-prindle aaron-prindle added kind/enhancement New feature or request help wanted Looking for a volunteer! good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment. meta/kaniko labels Nov 11, 2023
@tal66 tal66 mentioned this issue Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Looking for a volunteer! kind/enhancement New feature or request meta/kaniko priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rm bool param detectFilesystem in InitIgnoreList
1 participant
@aaron-prindle