Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded /kaniko directory from #2863 should be parameterized for usage w/ --kaniko-dir, etc. #2876

Open
aaron-prindle opened this issue Nov 29, 2023 · 0 comments
Labels
area/cli bugs related to kaniko CLI area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) easy-fix help wanted Looking for a volunteer! kind/bug Something isn't working priority/p2 High impact feature/bug. Will get a lot of users happy

Comments

@aaron-prindle
Copy link
Collaborator

aaron-prindle commented Nov 29, 2023

Currently the fix made in #2863 uses a hardcoded /kaniko directory but this can be changed by the user with the KANIKO_DIR env var or --kaniko-dir flag

NOTE: we might want to always have /kaniko skipped but additionally Skip the --kaniko-dir var as the /Kaniko dir in the image (vs just using the parameter). This is because the /kaniko dir in the image is pre-populated with files (Kaniko binary, etc.) that likely aren't desired for users to have in their image(s)

@aaron-prindle aaron-prindle added kind/bug Something isn't working help wanted Looking for a volunteer! easy-fix priority/p2 High impact feature/bug. Will get a lot of users happy area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) area/cli bugs related to kaniko CLI labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bugs related to kaniko CLI area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) easy-fix help wanted Looking for a volunteer! kind/bug Something isn't working priority/p2 High impact feature/bug. Will get a lot of users happy
Projects
None yet
Development

No branches or pull requests

1 participant