Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function SetEnvironmentVariable not used anywhere. #762

Closed
prary opened this issue Sep 6, 2019 · 3 comments
Closed

function SetEnvironmentVariable not used anywhere. #762

prary opened this issue Sep 6, 2019 · 3 comments
Labels
area/internal bugs related to kaniko development workflow easy-fix good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment.
Milestone
Release v1.1.0

Comments

@prary
Copy link
Contributor

prary commented Sep 6, 2019

Function defined in pkg/image/image.go but not referenced anywhere, possible reason for #754 #748 and few others

kaniko/pkg/image/image.go

Line 29 in 1d3cf8a

func SetEnvVariables(img v1.Image) error {

If this is dead code then it should be removed.
@prary prary mentioned this issue Sep 9, 2019
Closed
@tejal29 tejal29 added good first issue Good for newcomers meta/internal priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Sep 13, 2019
@tejal29
Copy link
Contributor

tejal29 commented Oct 2, 2019

Thanks @prary feel free to create a PR :)

@prary
Copy link
Contributor Author

prary commented Oct 7, 2019

PR containing deletion of the image.go file?

@tejal29 tejal29 added area/internal bugs related to kaniko development workflow and removed meta/internal labels Oct 16, 2019
@tejal29 tejal29 added this to the GA Release v1.0.0 milestone Jan 10, 2020
@dgzlopes
Copy link

dgzlopes commented Oct 1, 2020 •
edited
Loading

This issue is outdated, and I think it can safely be closed @tejal29. The /pkg/image folder is different now, and this code-block doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/internal bugs related to kaniko development workflow easy-fix good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
Release v1.1.0
Development

No branches or pull requests
4 participants
@tejal29 @aaron-prindle @prary @dgzlopes