Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document how to run the integration tests #798

Closed
victornoel opened this issue Oct 3, 2019 · 3 comments
Closed

Better document how to run the integration tests #798

victornoel opened this issue Oct 3, 2019 · 3 comments

Comments

@victornoel
Copy link
Contributor

victornoel commented Oct 3, 2019

Actual behavior

I run make integration-test and I get the following output:

++ GCS_BUCKET=gs://kaniko-test-bucket
++ IMAGE_REPO=gcr.io/kaniko-test
++ '[' -f /common.sh ']'
++ echo 'Running integration tests...'
Running integration tests...
++ make out/executor
make[1]: Entering directory '/home/victor/go/src/github.com/GoogleContainerTools/kaniko'
make[1]: 'out/executor' is up to date.
make[1]: Leaving directory '/home/victor/go/src/github.com/GoogleContainerTools/kaniko'
++ make out/warmer
make[1]: Entering directory '/home/victor/go/src/github.com/GoogleContainerTools/kaniko'
GOARCH=amd64 GOOS=linux CGO_ENABLED=0 go build -ldflags '-extldflags "-static" -X .version=v0.12.0 -w -s  ' -o out/warmer github.com/GoogleContainerTools/kaniko/cmd/warmer
make[1]: Leaving directory '/home/victor/go/src/github.com/GoogleContainerTools/kaniko'
++ pushd integration
~/go/src/github.com/GoogleContainerTools/kaniko/integration ~/go/src/github.com/GoogleContainerTools/kaniko
++ go test -v --bucket gs://kaniko-test-bucket --repo gcr.io/kaniko-test --timeout 30m
flag provided but not defined: -test.v
Usage of /tmp/go-build265984142/b001/integration.test:
  -alsologtostderr
    	log to standard error as well as files
  -bucket integration
    	The gcs bucket argument to uploaded the tar-ed contents of the integration dir to. (default "gs://kaniko-test-bucket")
  -log_backtrace_at value
    	when logging hits line file:N, emit a stack trace
  -log_dir string
    	If non-empty, write log files in this directory
  -logtostderr
    	log to standard error instead of files
  -repo gcloud
    	The (docker) image repo to build and push images to during the test. gcloud must be authenticated with this repo. (default "gcr.io/kaniko-test")
  -stderrthreshold value
    	logs at or above this threshold go to stderr
  -v value
    	log level for V logs
  -vmodule value
    	comma-separated list of pattern=N settings for file-filtered logging
exit status 2
FAIL	github.com/GoogleContainerTools/kaniko/integration	0.010s
make: *** [Makefile:54: integration-test] Error 1

Expected behavior

Either the tests are not working or I'm doing something wrong. I have no way to know if there are things I need to setup beforehand. For the record I just ran dep ensure before running the integration tests.

Additional Information

Using go version go1.13 linux/amd64 on archlinux

@victornoel
Copy link
Contributor Author

Seems I haven't read closely enough, this is documented in DEVELOPMENT.md

@tejal29
Copy link
Contributor

tejal29 commented Oct 4, 2019

Hi @victornoel this is recent issue issue with go1.13.
See golang/go#34443, golang/go#33475

Can you revert back to go1.12?

@victornoel
Copy link
Contributor Author

@tejal29 ah indeed, thanks for the feedback, I thought it was just me doing something wrong :)
I will try to see if I can, I'm not clear with go how to change the currently used go version (in js I would use nvm for example, in python pyenv, but in go I have no idea and my linux distribution is using 1.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants